Bug 100690

Summary: Support captions when PLUGIN_PROXY_FOR_VIDEO
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, feature-media-reviews, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch simon.fraser: review+

Eric Carlson
Reported 2012-10-29 11:06:51 PDT
Support text tracks when PLUGIN_PROXY_FOR_VIDEO is defined.
Attachments
Proposed patch (5.43 KB, patch)
2012-10-29 12:13 PDT, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2012-10-29 12:13:13 PDT
Created attachment 171289 [details] Proposed patch
Simon Fraser (smfr)
Comment 2 2012-10-29 12:44:13 PDT
Comment on attachment 171289 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=171289&action=review > Source/WebCore/rendering/RenderEmbeddedObject.cpp:258 > +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO) > + RenderBox* controlsRenderer = toRenderBox(m_children.firstChild()); I think it would be good to have a comment here pointing out that this code is duplicated from RenderVideo (or maybe even share code).
Eric Carlson
Comment 3 2012-10-29 13:02:14 PDT
http://trac.webkit.org/changeset/132842
Note You need to log in before you can comment on or make changes to this bug.