Bug 100690

Summary: Support captions when PLUGIN_PROXY_FOR_VIDEO
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Severity: Normal CC: eric, feature-media-reviews, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Proposed patch simon.fraser: review+

Description Eric Carlson 2012-10-29 11:06:51 PDT
Support text tracks when PLUGIN_PROXY_FOR_VIDEO is defined.
Comment 1 Eric Carlson 2012-10-29 12:13:13 PDT
Created attachment 171289 [details]
Proposed patch
Comment 2 Simon Fraser (smfr) 2012-10-29 12:44:13 PDT
Comment on attachment 171289 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171289&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:258
> +    RenderBox* controlsRenderer = toRenderBox(m_children.firstChild());

I think it would be good to have a comment here pointing out that this code is duplicated from RenderVideo (or maybe even share code).
Comment 3 Eric Carlson 2012-10-29 13:02:14 PDT