Bug 100683

Summary:

Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.

Product:

WebKit

Reporter:

dubroy

Component:

Web Inspector (Deprecated)

Assignee:

dubroy

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Screenshot of old look	none
Screenshot of new look.	none
Fixed style.	none

dubroy

Reported 2012-10-29 09:40:37 PDT

Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.

Attachments
Patch (2.05 KB, patch) 2012-10-29 09:42 PDT, dubroy	no flags	Details Formatted Diff Diff
Screenshot of old look (124.63 KB, image/png) 2012-10-29 09:43 PDT, dubroy	no flags	Details
Screenshot of new look. (114.34 KB, image/png) 2012-10-29 09:43 PDT, dubroy	no flags	Details
Fixed style. (2.05 KB, patch) 2012-10-29 09:49 PDT, dubroy	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

dubroy

Comment 1 2012-10-29 09:42:25 PDT

Created attachment 171263 [details] Patch

dubroy

Comment 2 2012-10-29 09:43:36 PDT

Created attachment 171266 [details] Screenshot of old look

dubroy

Comment 3 2012-10-29 09:43:54 PDT

Created attachment 171267 [details] Screenshot of new look.

WebKit Review Bot

Comment 4 2012-10-29 09:46:22 PDT

Attachment 171263 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

dubroy

Comment 5 2012-10-29 09:49:05 PDT

Created attachment 171269 [details] Fixed style.

Pavel Feldman

Comment 6 2012-10-29 09:53:31 PDT

Comment on attachment 171269 [details] Fixed style. What about undocked mode? Also, note that when themed, we are passing the theme colors into the front-end. We could pass gradients instead and push this data from downstream at runtime.

WebKit Review Bot

Comment 7 2012-10-29 10:51:59 PDT

Comment on attachment 171269 [details] Fixed style. Clearing flags on attachment: 171269 Committed r132821: <http://trac.webkit.org/changeset/132821>

WebKit Review Bot

Comment 8 2012-10-29 10:52:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.