| Summary: | [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, tony, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2012-10-29 05:28:33 PDT
Created attachment 171209 [details]
Patch
Comment on attachment 171209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171209&action=review > Tools/ChangeLog:10 > + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: You can add extra notes about the code change here. For example, it would have been helpful if you wrote that include_dirs and dependencies is redundant here because TestRunner already has these settings. Created attachment 171373 [details]
Patch
Comment on attachment 171373 [details] Patch Clearing flags on attachment: 171373 Committed r132872: <http://trac.webkit.org/changeset/132872> All reviewed patches have been landed. Closing bug. |