Bug 100642

Summary: [EFL][DRT] Bitmap should show whole view area.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, jungjik.lee, ktf.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95182    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch
none
patch none

Kangil Han
Reported 2012-10-29 02:04:40 PDT
css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
Attachments
patch (4.30 KB, patch)
2012-10-29 02:11 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
patch (8.85 KB, patch)
2012-10-29 22:14 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
patch (8.85 KB, patch)
2012-10-29 22:20 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-10-29 02:11:40 PDT
Created attachment 171180 [details] patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-10-29 02:26:38 PDT
Comment on attachment 171180 [details] patch What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?
Kangil Han
Comment 3 2012-10-29 02:42:33 PDT
(In reply to comment #2) > What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? (100, 100, 800, 600) >How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600? Would you please elaborate this comment more?
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-10-29 05:12:30 PDT
(In reply to comment #3) > (In reply to comment #2) > > What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? > > (100, 100, 800, 600) Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT? > >How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600? > > Would you please elaborate this comment more? See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image.
Kangil Han
Comment 5 2012-10-29 22:14:37 PDT
Created attachment 171371 [details] patch
Kangil Han
Comment 6 2012-10-29 22:16:30 PDT
(In reply to comment #4) > Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT? Yes, it is. ;) > See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image. Done. :)
WebKit Review Bot
Comment 7 2012-10-29 22:17:24 PDT
Attachment 171371 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp:50: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kangil Han
Comment 8 2012-10-29 22:20:10 PDT
Created attachment 171372 [details] patch Fix style error. :P
Raphael Kubo da Costa (:rakuco)
Comment 9 2012-10-30 02:05:19 PDT
Looks good, thanks!
WebKit Review Bot
Comment 10 2012-10-30 02:40:24 PDT
Comment on attachment 171372 [details] patch Clearing flags on attachment: 171372 Committed r132885: <http://trac.webkit.org/changeset/132885>
WebKit Review Bot
Comment 11 2012-10-30 02:40:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.