Bug 100623

Summary: [TexMap] Make GraphicsLayerAnimation choose a proper timing function.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Dongseong Hwang 2012-10-28 20:39:13 PDT
Previously, GraphicsLayerAnimation choosed a timing function in the wrong way.
Other GraphicsLayers choose a timing function in the similar way to
GraphicsLayerCA::timingFunctionForAnimationValue(). The way consists of the
following steps.
1. Try to query the timing function of the current keyframe animation value.
2. If the timing function of #1 is null, try to query the timing function of Animation.
3. If the timing function of #2 is null, return CubicBezierTimingFunction::defaultTimingFunction().

This patch makes GraphicsLayerAnimation choose a timing function in the same way
to others.
Comment 1 Dongseong Hwang 2012-10-28 20:41:51 PDT
Created attachment 171149 [details]
Patch
Comment 2 Noam Rosenthal 2012-10-28 21:21:06 PDT
Comment on attachment 171149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171149&action=review

> Source/WebCore/ChangeLog:8
> +        Previously, GraphicsLayerAnimation choosed a timing function in the wrong way.

Currently, GraphicsLayerAnimation chooses a timing function in the wrong way.

> Source/WebCore/ChangeLog:17
> +        to others.

to other implementations.
Comment 3 Dongseong Hwang 2012-10-29 00:18:21 PDT
Created attachment 171166 [details]
Patch
Comment 4 Dongseong Hwang 2012-10-29 00:19:03 PDT
(In reply to comment #2)
Thank you for your review :)

> (From update of attachment 171149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171149&action=review
> 
> Currently, GraphicsLayerAnimation chooses a timing function in the wrong way.

Done.

> 
> to other implementations.

Done.
Comment 5 WebKit Review Bot 2012-10-29 07:27:05 PDT
Comment on attachment 171166 [details]
Patch

Clearing flags on attachment: 171166

Committed r132798: <http://trac.webkit.org/changeset/132798>
Comment 6 WebKit Review Bot 2012-10-29 07:27:08 PDT
All reviewed patches have been landed.  Closing bug.