Bug 100614

Summary: [BlackBerry] Simplify AuthenticationChallengeManager::instance
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch yong.li.webkit: review+

Rob Buis
Reported 2012-10-28 13:39:39 PDT
SSIA
Attachments
Patch (4.21 KB, patch)
2012-10-28 13:44 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.31 KB, patch)
2012-10-29 13:30 PDT, Rob Buis 		yong.li.webkit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-10-28 13:44:47 PDT
Created attachment 171141 [details] Patch
Jacky Jiang
Comment 2 2012-10-29 08:04:17 PDT
Comment on attachment 171141 [details] Patch It is the same as this: static AuthenticationChallengeManager* s_manager = new AuthenticationChallengeManager(); return s_manager; right? What about DEFINE_STATIC_LOCAL?
Rob Buis
Comment 3 2012-10-29 13:30:16 PDT
Created attachment 171299 [details] Patch
Yong Li
Comment 4 2012-10-29 14:35:59 PDT
Comment on attachment 171299 [details] Patch LGTM. might want to add Lyon as internal reviewer?
Rob Buis
Comment 5 2012-10-29 14:54:47 PDT
Committed r132851: <http://trac.webkit.org/changeset/132851>
Note You need to log in before you can comment on or make changes to this bug.