Bug 100553

Summary:

[chromium] Allow implicit conversion between gfx::Vector2d and WebSize

Product:

WebKit

Reporter:

Dana Jansens <danakj>

Component:

New Bugs

Assignee:

Dana Jansens <danakj>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, backer, cc-bugs, dglazkov, fishd, jamesr, piman, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Dana Jansens

Reported 2012-10-26 12:47:05 PDT

[chromium] Allow implicit conversion between gfx::Vector2d and WebSize

Attachments
Patch (2.05 KB, patch) 2012-10-26 12:48 PDT, Dana Jansens	no flags	Details Formatted Diff Diff
Patch (2.05 KB, patch) 2012-10-26 13:30 PDT, Dana Jansens	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dana Jansens

Comment 1 2012-10-26 12:48:09 PDT

Created attachment 170986 [details] Patch

Dana Jansens

Comment 2 2012-10-26 12:48:26 PDT

This depends on https://codereview.chromium.org/11269022/ for gfx::Vector2d to exist.

WebKit Review Bot

Comment 3 2012-10-26 12:54:43 PDT

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

James Robinson

Comment 4 2012-10-26 13:12:42 PDT

Comment on attachment 170986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170986&action=review Be sure to reverse-roll before landing this > Source/Platform/ChangeLog:9 > + IntSize class is used equivalently inside WebCore. This let's us convert It's "lets", not "let's". (insert favorite apostrophe meme here)

WebKit Review Bot

Comment 5 2012-10-26 13:19:31 PDT

Comment on attachment 170986 [details] Patch Attachment 170986 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14605235

Dana Jansens

Comment 6 2012-10-26 13:30:36 PDT

Created attachment 170992 [details] Patch

Dana Jansens

Comment 7 2012-10-26 13:30:50 PDT

(In reply to comment #4) > (From update of attachment 170986 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170986&action=review > > Be sure to reverse-roll before landing this Yup! Thanks :)

WebKit Review Bot

Comment 8 2012-11-01 09:03:20 PDT

Comment on attachment 170992 [details] Patch Rejecting attachment 170992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: '&' token Source/Platform/chromium/public/WebSize.h:101: error: 'WebKit::WebSize& WebKit::WebSize::operator=(...)' must not have variable number of arguments Source/Platform/chromium/public/WebSize.h:101: error: expected ';' before '&' token Source/Platform/chromium/public/WebSize.h:108: error: expected ';' before 'operator' Source/Platform/chromium/public/WebSize.h:113: error: expected type-specifier make: *** [out/Release/obj.target/cc/Source/WebKit/chromium/cc/layer_tree_host_impl.o] Error 1 Full output: http://queues.webkit.org/results/14686554

WebKit Review Bot

Comment 9 2012-11-01 11:36:52 PDT

Comment on attachment 170992 [details] Patch Clearing flags on attachment: 170992 Committed r133198: <http://trac.webkit.org/changeset/133198>

WebKit Review Bot

Comment 10 2012-11-01 11:36:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.