Bug 10054
| Summary: | ICU should be abstracted out from WebCore | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, hyatt, mitz, sam |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | All | ||
| OS: | All | ||
Antti Koivisto
ICU library can not be used on all platforms. For example it is far too big to use in mobile devices. There should be a unicode abstraction layer (like JSC already has) which can map to ICU or some platform functionality. Creating a bug for tracking this.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
George Staikos has begun doing just this on the Unity project (branch?) and I am looking into working it back into the trunk.
Alexey Proskuryakov
Done by Lars Knoll and Hyatt in r18098.
David Kilzer (:ddkilzer)
(In reply to comment #2)
> Done by Lars Knoll and Hyatt in r18098.
Follow-up build fixes in r18099-r18105.
Alexey Proskuryakov
> > Done by Lars Knoll and Hyatt in r18098.
> Follow-up build fixes in r18099-r18105.
This change has caused a failure in tables/mozilla/bugs/bug33855.html
mitz
(In reply to comment #4)
> > > Done by Lars Knoll and Hyatt in r18098.
> > Follow-up build fixes in r18099-r18105.
>
> This change has caused a failure in tables/mozilla/bugs/bug33855.html
>
Specifically this change in StringImpl.cpp:
- return c <= 0x7F ? isspace(c) : (u_charDirection(c) == U_WHITE_SPACE_NEUTRAL);
+ return c <= 0x7F ? isspace(c) : WTF::Unicode::isSpace(c);
Dave Hyatt
Heh I caught that line in review and asked if it was still equivalent. I guess it isn't.
Dave Hyatt
Let's get a regression bug filed.
mitz
(In reply to comment #7)
> Let's get a regression bug filed.
>
Bug 11795.