Bug 100530

Summary: Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description eustas.bug 2012-10-26 08:52:05 PDT
Motivation: cpu-monitoring feature looks like a glitch, when it is not supported by browser.
Comment 1 eustas.bug 2012-10-26 09:07:51 PDT
Created attachment 170942 [details]
Patch
Comment 2 Yury Semikhatsky 2012-10-29 00:04:12 PDT
Comment on attachment 170942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review

> Source/WebCore/inspector/InspectorClient.h:60
> +    virtual bool supportsMainThreadMonitoring() { return false; }

Please rename it to canMainThreadMonitoring for consistency with other similar methods on the client.
Comment 3 eustas.bug 2012-10-29 01:28:45 PDT
Comment on attachment 170942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review

>> Source/WebCore/inspector/InspectorClient.h:60
>> +    virtual bool supportsMainThreadMonitoring() { return false; }
> 
> Please rename it to canMainThreadMonitoring for consistency with other similar methods on the client.

done
Comment 4 eustas.bug 2012-10-29 01:33:18 PDT
Created attachment 171176 [details]
Patch
Comment 5 WebKit Review Bot 2012-10-29 05:40:23 PDT
Comment on attachment 171176 [details]
Patch

Clearing flags on attachment: 171176

Committed r132788: <http://trac.webkit.org/changeset/132788>
Comment 6 WebKit Review Bot 2012-10-29 05:40:26 PDT
All reviewed patches have been landed.  Closing bug.