Bug 100530

Summary: Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

eustas.bug
Reported 2012-10-26 08:52:05 PDT
Motivation: cpu-monitoring feature looks like a glitch, when it is not supported by browser.
Attachments
Patch (9.00 KB, patch)
2012-10-26 09:07 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (8.87 KB, patch)
2012-10-29 01:33 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-10-26 09:07:51 PDT
Created attachment 170942 [details] Patch
Yury Semikhatsky
Comment 2 2012-10-29 00:04:12 PDT
Comment on attachment 170942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review > Source/WebCore/inspector/InspectorClient.h:60 > + virtual bool supportsMainThreadMonitoring() { return false; } Please rename it to canMainThreadMonitoring for consistency with other similar methods on the client.
eustas.bug
Comment 3 2012-10-29 01:28:45 PDT
Comment on attachment 170942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review >> Source/WebCore/inspector/InspectorClient.h:60 >> + virtual bool supportsMainThreadMonitoring() { return false; } > > Please rename it to canMainThreadMonitoring for consistency with other similar methods on the client. done
eustas.bug
Comment 4 2012-10-29 01:33:18 PDT
Created attachment 171176 [details] Patch
WebKit Review Bot
Comment 5 2012-10-29 05:40:23 PDT
Comment on attachment 171176 [details] Patch Clearing flags on attachment: 171176 Committed r132788: <http://trac.webkit.org/changeset/132788>
WebKit Review Bot
Comment 6 2012-10-29 05:40:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.