Summary: | Web Inspector: instrument chromium GlyphCache. It keeps ~2mb. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||||
Status: | RESOLVED WONTFIX | ||||||||||
Severity: | Normal | CC: | apavlov, dglazkov, keishi, loislo, ossy, peter+ews, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 100596 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2012-10-26 06:49:49 PDT
Created attachment 170921 [details]
Patch
Comment on attachment 170921 [details] Patch Attachment 170921 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14608104 Comment on attachment 170921 [details] Patch Attachment 170921 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14608105 Comment on attachment 170921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170921&action=review > Source/WebCore/ChangeLog:3 > + Web Inspector: instrument chromium GlyphCache. It keeps ~2mb. ~2mb on what page? > Source/WebCore/ChangeLog:9 > + Can you add a test for this? > Source/WebCore/platform/PlatformMemoryInstrumentation.cpp:38 > +MemoryObjectType PlatformMemoryTypes::GlyphCache = "MemoryCache.GlyphCache"; I'd rather use Fonts.GlyphCache instead of MemoryCache.GlyphCache. Committed r132658: <http://trac.webkit.org/changeset/132658> Reverted r132658 for reason: It broke the Qt build Committed r132661: <http://trac.webkit.org/changeset/132661> Please don't ignore the EWS bots! Created attachment 170938 [details]
Patch
Committed r132725: <http://trac.webkit.org/changeset/132725> Re-opened since this is blocked by bug 100596 Created attachment 171393 [details]
would not compile on chromium without skia patch
Comment on attachment 171393 [details] would not compile on chromium without skia patch Attachment 171393 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14632405 Comment on attachment 171393 [details] would not compile on chromium without skia patch Attachment 171393 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14630445 Comment on attachment 171393 [details]
would not compile on chromium without skia patch
Is this still relevant?
Comment on attachment 171393 [details]
would not compile on chromium without skia patch
Please re-request review in case still relevant
Chromium has left the building. Won't fix. |