Bug 100515

Summary: Web Inspector: instrument chromium GlyphCache. It keeps ~2mb.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED WONTFIX    
Severity: Normal CC: apavlov, dglazkov, keishi, loislo, ossy, peter+ews, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 100596    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
would not compile on chromium without skia patch peter+ews: commit-queue-

Description Ilya Tikhonovsky 2012-10-26 06:49:49 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-10-26 07:24:21 PDT 
Created attachment 170921 [details]
Patch
Comment 2 Early Warning System Bot 2012-10-26 07:36:49 PDT 
Comment on attachment 170921 [details]
Patch

Attachment 170921 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14608104
Comment 3 Early Warning System Bot 2012-10-26 07:37:40 PDT 
Comment on attachment 170921 [details]
Patch

Attachment 170921 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14608105
Comment 4 Yury Semikhatsky 2012-10-26 07:37:47 PDT 
Comment on attachment 170921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170921&action=review

> Source/WebCore/ChangeLog:3
> +        Web Inspector: instrument chromium GlyphCache. It keeps ~2mb.

~2mb on what page?

> Source/WebCore/ChangeLog:9
> +

Can you add a test for this?

> Source/WebCore/platform/PlatformMemoryInstrumentation.cpp:38
> +MemoryObjectType PlatformMemoryTypes::GlyphCache = "MemoryCache.GlyphCache";

I'd rather use Fonts.GlyphCache instead of MemoryCache.GlyphCache.
Comment 5 Ilya Tikhonovsky 2012-10-26 08:08:04 PDT 
Committed r132658: <http://trac.webkit.org/changeset/132658>
Comment 6 Csaba Osztrogonác 2012-10-26 08:33:52 PDT 
Reverted r132658 for reason:

It broke the Qt build

Committed r132661: <http://trac.webkit.org/changeset/132661>
Comment 7 Csaba Osztrogonác 2012-10-26 08:34:14 PDT 
Please don't ignore the EWS bots!
Comment 8 Ilya Tikhonovsky 2012-10-26 08:51:36 PDT 
Created attachment 170938 [details]
Patch
Comment 9 Ilya Tikhonovsky 2012-10-27 08:11:48 PDT 
Committed r132725: <http://trac.webkit.org/changeset/132725>
Comment 10 WebKit Review Bot 2012-10-27 09:04:28 PDT 
Re-opened since this is blocked by bug 100596
Comment 11 Ilya Tikhonovsky 2012-10-30 01:27:53 PDT 
Created attachment 171393 [details]
would not compile on chromium without skia patch
Comment 12 Peter Beverloo (cr-android ews) 2012-10-30 01:37:35 PDT 
Comment on attachment 171393 [details]
would not compile on chromium without skia patch

Attachment 171393 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14632405
Comment 13 WebKit Review Bot 2012-10-30 02:01:55 PDT 
Comment on attachment 171393 [details]
would not compile on chromium without skia patch

Attachment 171393 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14630445
Comment 14 Pavel Feldman 2012-11-13 23:57:36 PST 
Comment on attachment 171393 [details]
would not compile on chromium without skia patch

Is this still relevant?
Comment 15 Pavel Feldman 2012-11-14 00:05:08 PST 
Comment on attachment 171393 [details]
would not compile on chromium without skia patch

Please re-request review in case still relevant
Comment 16 Timothy Hatcher 2013-04-05 13:16:44 PDT 
Chromium has left the building. Won't fix.