Bug 100482

Summary: Refactor Localizer-related classes.
Product: WebKit Reporter: Kent Tamura <tkent>
Component: PlatformAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing 2 none

Kent Tamura
Reported 2012-10-26 01:33:09 PDT
- Localizer has unused code - Some Localizer subclasses hide Localizer data members - Should use String::isNull to check initialization-or-not
Attachments
Patch (12.71 KB, patch)
2012-10-26 01:42 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.13 KB, patch)
2012-10-26 03:05 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing 2 (13.17 KB, patch)
2012-10-26 06:28 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-26 01:42:58 PDT
Created attachment 170849 [details] Patch
Kentaro Hara
Comment 2 2012-10-26 01:51:03 PDT
Comment on attachment 170849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170849&action=review > Source/WebCore/platform/text/LocaleNone.cpp:150 > + if (!m_timeAMPMLabels.isEmpty()) isNull() ?
Kent Tamura
Comment 3 2012-10-26 01:52:30 PDT
Comment on attachment 170849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170849&action=review >> Source/WebCore/platform/text/LocaleNone.cpp:150 >> + if (!m_timeAMPMLabels.isEmpty()) > > isNull() ? No. This is a Vector.
WebKit Review Bot
Comment 4 2012-10-26 03:03:05 PDT
Comment on attachment 170849 [details] Patch Attachment 170849 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14607006
Kent Tamura
Comment 5 2012-10-26 03:05:04 PDT
Created attachment 170863 [details] Patch for landing Fix LocaleICU build
WebKit Review Bot
Comment 6 2012-10-26 03:50:16 PDT
Comment on attachment 170863 [details] Patch for landing Attachment 170863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14609015
Kent Tamura
Comment 7 2012-10-26 06:28:13 PDT
Created attachment 170909 [details] Patch for landing 2
WebKit Review Bot
Comment 8 2012-10-26 07:23:07 PDT
Comment on attachment 170909 [details] Patch for landing 2 Clearing flags on attachment: 170909 Committed r132650: <http://trac.webkit.org/changeset/132650>
WebKit Review Bot
Comment 9 2012-10-26 07:23:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.