Bug 100458

Summary: [chromium] Allow embedder to enter/leave force compositing mode
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, roger_fong, tkent+wkapi, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
work in progress
none
Patch
none
With more null checks so it can be called earlier none

James Robinson
Reported 2012-10-25 22:07:21 PDT
[chromium] Allow embedder to enter/leave force compositing mode
Attachments
work in progress (12.15 KB, patch)
2012-10-25 22:08 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (3.71 KB, patch)
2012-10-26 13:14 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
With more null checks so it can be called earlier (3.84 KB, patch)
2012-10-26 13:57 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-10-25 22:08:22 PDT
Created attachment 170809 [details] work in progress
James Robinson
Comment 2 2012-10-26 13:14:09 PDT
Created attachment 170989 [details] Patch
WebKit Review Bot
Comment 3 2012-10-26 13:15:37 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2012-10-26 13:16:53 PDT
After discussing with Enne I think the threaded mode solution will look a bit different and won't involve WebWidget interactions. This patch will still work fine for the single threaded path.
Adrienne Walker
Comment 5 2012-10-26 13:22:05 PDT
Comment on attachment 170989 [details] Patch R=me.
James Robinson
Comment 6 2012-10-26 13:57:05 PDT
Created attachment 170997 [details] With more null checks so it can be called earlier
Adrienne Walker
Comment 7 2012-10-26 15:06:38 PDT
Comment on attachment 170997 [details] With more null checks so it can be called earlier R=meagain.
WebKit Review Bot
Comment 8 2012-10-26 16:03:42 PDT
Comment on attachment 170997 [details] With more null checks so it can be called earlier Clearing flags on attachment: 170997 Committed r132708: <http://trac.webkit.org/changeset/132708>
WebKit Review Bot
Comment 9 2012-10-26 16:03:48 PDT
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 10 2012-10-27 09:23:15 PDT
There are about 15 crashes on each of the bots (Apple-Mac and Apple-Windows) that relate to compositing. http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29310 It looks like within the regression range that this change is the most relevant. Do you think this could be causing the failures?
Adam Barth
Comment 11 2012-10-27 11:02:23 PDT
> Do you think this could be causing the failures? This code is not compiled for apple-mac or apple-win.
Note You need to log in before you can comment on or make changes to this bug.