Bug 100386

Summary: [Qt] Enable JSC's disassembler on x86, x86_64 Linux
Product: WebKit Reporter: Gabor Ballabas <gaborb>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, benjamin, gaborb, hausmann, kkristof, ossy, vestbo, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch hausmann: review+, hausmann: commit-queue-

Gabor Ballabas
Reported 2012-10-25 09:23:51 PDT
It works fine on Linux x86, x86_64 just needs to be enabled in the QtWebKit build system.
Attachments
Patch (4.50 KB, patch)
2012-10-25 09:30 PDT, Gabor Ballabas 		hausmann: review+
hausmann: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Ballabas
Comment 1 2012-10-25 09:30:27 PDT
Created attachment 170671 [details] Patch
Simon Hausmann
Comment 2 2012-10-26 00:28:47 PDT
Comment on attachment 170671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170671&action=review LGTM, but I suggest to use an if() before landing. > Source/JavaScriptCore/DerivedSources.pri:108 > +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") { I suggest to write this as linux-*:if(isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64")) { to be on the very safe side. > Source/JavaScriptCore/JavaScriptCore.pri:42 > +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") { Same here
Kristóf Kosztyó
Comment 3 2012-10-26 03:51:26 PDT
Committed r132606: <http://trac.webkit.org/changeset/132606>
Note You need to log in before you can comment on or make changes to this bug.