Bug 100383

Summary: [WK2] Enable delegate scrolling as soon as the FrameView is created if we're using fixed layout
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, bdakin, jturcotte, kenneth, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100900    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch kenneth: review+

Jocelyn Turcotte
Reported 2012-10-25 08:29:40 PDT
[WK2] Enable delegate scrolling as soon as the FrameView is created if we're using fixed layout
Attachments
Patch (6.89 KB, patch)
2012-10-25 09:02 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2012-11-01 08:01 PDT, Jocelyn Turcotte 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-10-25 09:02:15 PDT
Created attachment 170664 [details] Patch
WebKit Review Bot
Comment 2 2012-10-29 03:28:18 PDT
Comment on attachment 170664 [details] Patch Clearing flags on attachment: 170664 Committed r132780: <http://trac.webkit.org/changeset/132780>
WebKit Review Bot
Comment 3 2012-10-29 03:28:21 PDT
All reviewed patches have been landed. Closing bug.
Beth Dakin
Comment 4 2012-10-31 15:13:54 PDT
This introduced some undesired behavior on Mac. The call to: m_page->settings()->setAcceleratedCompositingForFixedPositionEnabled(fixed); is not right for Mac.
Simon Fraser (smfr)
Comment 5 2012-10-31 15:14:58 PDT
Should that code only run if delegated scrolling is being used?
WebKit Review Bot
Comment 6 2012-10-31 16:20:07 PDT
Re-opened since this is blocked by bug 100900
Jocelyn Turcotte
Comment 7 2012-11-01 08:01:04 PDT
Created attachment 171853 [details] Patch Since the rollout hasn't been landed yet I'm uploading a fix here directly. It is quite wrong to allow those settings to be set to false in every case.
Jocelyn Turcotte
Comment 8 2012-11-01 08:19:38 PDT
Committed r133176: <http://trac.webkit.org/changeset/133176>
Note You need to log in before you can comment on or make changes to this bug.