Bug 100383

Summary:

[WK2] Enable delegate scrolling as soon as the FrameView is created if we're using fixed layout

Product:

WebKit

Reporter:

Jocelyn Turcotte <jturcotte>

Component:

New Bugs

Assignee:

Jocelyn Turcotte <jturcotte>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, bdakin, jturcotte, kenneth, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

100900

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	kenneth: review+

Description Jocelyn Turcotte 2012-10-25 08:29:40 PDT

[WK2] Enable delegate scrolling as soon as the FrameView is created if we're using fixed layout

Comment 1 Jocelyn Turcotte 2012-10-25 09:02:15 PDT

Created attachment 170664 [details]
Patch

Comment 2 WebKit Review Bot 2012-10-29 03:28:18 PDT

Comment on attachment 170664 [details]
Patch

Clearing flags on attachment: 170664

Committed r132780: <http://trac.webkit.org/changeset/132780>

Comment 3 WebKit Review Bot 2012-10-29 03:28:21 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Beth Dakin 2012-10-31 15:13:54 PDT

This introduced some undesired behavior on Mac. The call to:

    m_page->settings()->setAcceleratedCompositingForFixedPositionEnabled(fixed);

is not right for Mac.

Comment 5 Simon Fraser (smfr) 2012-10-31 15:14:58 PDT

Should that code only run if delegated scrolling is being used?

Comment 6 WebKit Review Bot 2012-10-31 16:20:07 PDT

Re-opened since this is blocked by bug 100900

Comment 7 Jocelyn Turcotte 2012-11-01 08:01:04 PDT

Created attachment 171853 [details]
Patch

Since the rollout hasn't been landed yet I'm uploading a fix here directly.
It is quite wrong to allow those settings to be set to false in every case.

Comment 8 Jocelyn Turcotte 2012-11-01 08:19:38 PDT

Committed r133176: <http://trac.webkit.org/changeset/133176>