Bug 100360

Summary: [Qt] REGRESSION(r128174): Fast build path doesn't work now
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Critical CC: dbates, hausmann, jbadics, ossy, vestbo, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: All   
OS: All   
Attachments:
Description Flags
build log on Debian Squeeze
none
build log on Ubuntu 11.10
none
Patch none

Csaba Osztrogonác
Reported 2012-10-25 03:52:10 PDT
It seems fast build path triggered by build-webkit doesn't work. When qmake isn't called at all, only make to avoid ~1.5-2 minutes runtime of qmake. I'll attach build logs soon.
Attachments
build log on Debian Squeeze (58.89 KB, text/plain)
2012-10-25 04:08 PDT, Csaba Osztrogonác 		no flags
Details
build log on Ubuntu 11.10 (57.47 KB, text/plain)
2012-10-25 04:37 PDT, Csaba Osztrogonác 		no flags
Details
Patch (2.19 KB, patch)
2012-11-20 06:01 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-10-25 04:08:52 PDT
Created attachment 170606 [details] build log on Debian Squeeze It seems build-webkit calls simple make, but somehow make calls qmake too always.
Csaba Osztrogonác
Comment 2 2012-10-25 04:37:14 PDT
Created attachment 170615 [details] build log on Ubuntu 11.10
Csaba Osztrogonác
Comment 3 2012-10-25 04:37:52 PDT
Tor Arne, have you got any idea what happens here?
Tor Arne Vestbø
Comment 4 2012-10-25 04:57:59 PDT
(In reply to comment #0) > It seems fast build path triggered by build-webkit doesn't work. Fast path? > When qmake isn't called at all, only make to avoid ~1.5-2 minutes > runtime of qmake. I can't parse this :)
Csaba Osztrogonác
Comment 5 2012-10-25 05:01:03 PDT
There are 3 different path: - make (only make called) - make incremental (qmake and make called) - make wipeclean && make incremental I meant the first one which doesn't work now. See the logs, qmake always run, but it shouldn't.
Csaba Osztrogonác
Comment 6 2012-11-04 00:51:08 PDT
ping?
Tor Arne Vestbø
Comment 7 2012-11-05 01:40:56 PST
(In reply to comment #5) > There are 3 different path: > - make (only make called) > - make incremental (qmake and make called) > - make wipeclean && make incremental > > I meant the first one which doesn't work now. > See the logs, qmake always run, but it shouldn't. I'll have a look.
Csaba Osztrogonác
Comment 8 2012-11-20 05:28:06 PST
We checked it with dicska and determined that r128174 is the culprit. The problem in nutshell: the SVN revision of last success build is appended at the end of WebKitBuild/Relase/.qmake.cache after the build is finished. But _all_ makefiles depends on .qmake.cache and this dependency triggers run qmake / regenerate makefiles _always_, because .qmake.cache is _always_ newer than any makefile. Previously WebKitBuild/Relase/.webkit.config contained the SVN revision which isn't dependency of any makefile. And .qmake.cache - dependency of all makefile - wasn't updated always. Any idea how to fix it?
Csaba Osztrogonác
Comment 9 2012-11-20 05:29:35 PST
r128174 - http://trac.webkit.org/changeset/128174 - This revision got rid .webkit.config / merge it to .qmake.cache.
Csaba Osztrogonác
Comment 10 2012-11-20 06:01:47 PST
Created attachment 175199 [details] Patch
Tor Arne Vestbø
Comment 11 2012-11-20 06:06:39 PST
Comment on attachment 175199 [details] Patch Ouch. Yeah, this is probably the best option.
Csaba Osztrogonác
Comment 12 2012-11-20 06:12:39 PST
Comment on attachment 175199 [details] Patch Clearing flags on attachment: 175199 Committed r135275: <http://trac.webkit.org/changeset/135275>
Csaba Osztrogonác
Comment 13 2012-11-20 06:12:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.