Bug 100356

Summary: Conditionalize XHR timeout support
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: WebCore Misc.Assignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, abecsi, alex, dbates, gyuyoung.kim, kenneth, ojan, rakuco, syoichi, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Dominik Röttsches (drott) 2012-10-25 01:57:25 PDT
abarth has asked to conditionalize xhr timeout support for ports that don't support it so that feature detection on web sites works.
Comment 1 Kenneth Rohde Christiansen 2012-10-25 06:04:58 PDT
Link to spec?
Comment 2 Dominik Röttsches (drott) 2012-10-25 06:18:28 PDT
http://www.w3.org/TR/XMLHttpRequest/#the-timeout-attribute

Implementation was discussed already and landed in bug 74802.
Comment 3 Dominik Röttsches (drott) 2012-10-25 06:45:10 PDT
Created attachment 170630 [details]
Patch
Comment 4 Adam Barth 2012-10-25 10:45:59 PDT
Comment on attachment 170630 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-10-25 12:27:01 PDT
Comment on attachment 170630 [details]
Patch

Clearing flags on attachment: 170630

Committed r132513: <http://trac.webkit.org/changeset/132513>
Comment 6 WebKit Review Bot 2012-10-25 12:27:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Kent Tamura 2012-10-25 19:17:54 PDT
Would you update http://trac.webkit.org/wiki/FeatureFlags please?
Comment 8 Dominik Röttsches (drott) 2012-10-26 04:02:33 PDT
(In reply to comment #7)
> Would you update http://trac.webkit.org/wiki/FeatureFlags please?

Done, https://trac.webkit.org/wiki/FeatureFlags#XHR_TIMEOUT