Bug 100337 – Web Inspector: Add "print" menu to Audits panel

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

Quote: "When data is accumulated, it is most useful if it can be exported and/or printed for further review and sharing."

[Alexander Pavlov (apavlov)]

Upstreaming http://code.google.com/p/chromium/issues/detail?id=156610

This feature would require DOM-tree and JS-state serialization (for extensions).
I propose to postpone it.

Created attachment 171430 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 171430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171430&action=review

> Source/WebCore/inspector/front-end/View.js:366
> +        output.textContent = '';

We use Element.prototype.removeChildren() for consistency (defined in DOMExtensions.js). I have a few more concerns:
- All Audits panel-specific styles will be broken when printing this way. You'll most certainly want to set up print-specific styles in this case?
- Why are you clearing the printable-area at this point? It should be empty given the clearing code below. I guess a better option would be declaring this function as WebInspector.printElement(element) and use it as a single entry point to printing element contents.

> Source/WebCore/inspector/front-end/View.js:369
> +        output.textContent = '';

Ditto

> Source/WebCore/inspector/front-end/inspector.css:3006
> +    #printable-area {

please move #printable-area-specific rules to the top, since they are the most important ones (and serve as a doc for this @media rule)

Created attachment 171434 [details]
Sample output

Created attachment 171445 [details]
Patch

Comment on attachment 171430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171430&action=review

>> Source/WebCore/inspector/front-end/View.js:366
>> +        output.textContent = '';
> 
> We use Element.prototype.removeChildren() for consistency (defined in DOMExtensions.js). I have a few more concerns:
> - All Audits panel-specific styles will be broken when printing this way. You'll most certainly want to set up print-specific styles in this case?
> - Why are you clearing the printable-area at this point? It should be empty given the clearing code below. I guess a better option would be declaring this function as WebInspector.printElement(element) and use it as a single entry point to printing element contents.

Addressed. Thanks.

>> Source/WebCore/inspector/front-end/View.js:369
>> +        output.textContent = '';
> 
> Ditto

Fixed.

>> Source/WebCore/inspector/front-end/inspector.css:3006
>> +    #printable-area {
> 
> please move #printable-area-specific rules to the top, since they are the most important ones (and serve as a doc for this @media rule)

Done.

[Pavel Feldman]

We don't have print for anything at the moment, I don't think it is worth starting with Audits for the printing functionality. I'd rather export it instead.

[Pavel Feldman]

Comment on attachment 171445 [details]
Patch

Clearing r? from the closed bug.