Bug 100371 - Web Inspector: JsDoc-annotate Audits panel code
Summary: Web Inspector: JsDoc-annotate Audits panel code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL:
Keywords:
Depends on:
Blocks: 100337
  Show dependency tree / graph
 
Reported: 2012-10-25 05:48 PDT by eustas.bug
Modified: 2012-10-26 02:06 PDT (History)
14 users (show)

See Also:

Attachments
Patch (22.22 KB, patch)
2012-10-25 06:08 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-10-25 05:48:38 PDT 
This is a preparation step for ongoing refactoring.
It is much easier to read doctyped code.
Comment 1 eustas.bug 2012-10-25 06:08:04 PDT 
Created attachment 170622 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-10-25 23:14:13 PDT 
Comment on attachment 170622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170622&action=review

> Source/WebCore/inspector/front-end/AuditsPanel.js:320
> +            ruleResultCallback(result);

Have you made sure none of the callbacks use "this"?
Comment 3 eustas.bug 2012-10-26 01:20:55 PDT 
Comment on attachment 170622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170622&action=review

>> Source/WebCore/inspector/front-end/AuditsPanel.js:320
>> +            ruleResultCallback(result);
> 
> Have you made sure none of the callbacks use "this"?

There is only one callback and it is already bound to its issuer object, so applying here has no effect.
Comment 4 WebKit Review Bot 2012-10-26 02:06:50 PDT 
Comment on attachment 170622 [details]
Patch

Clearing flags on attachment: 170622

Committed r132588: <http://trac.webkit.org/changeset/132588>
Comment 5 WebKit Review Bot 2012-10-26 02:06:55 PDT 
All reviewed patches have been landed.  Closing bug.