RESOLVED FIXED 100371
Web Inspector: JsDoc-annotate Audits panel code 
https://bugs.webkit.org/show_bug.cgi?id=100371
Summary Web Inspector: JsDoc-annotate Audits panel code
eustas.bug
Reported 2012-10-25 05:48:38 PDT
This is a preparation step for ongoing refactoring. It is much easier to read doctyped code.
Attachments
Patch (22.22 KB, patch)
2012-10-25 06:08 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-10-25 06:08:04 PDT
Created attachment 170622 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2012-10-25 23:14:13 PDT
Comment on attachment 170622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170622&action=review > Source/WebCore/inspector/front-end/AuditsPanel.js:320 > + ruleResultCallback(result); Have you made sure none of the callbacks use "this"?
eustas.bug
Comment 3 2012-10-26 01:20:55 PDT
Comment on attachment 170622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170622&action=review >> Source/WebCore/inspector/front-end/AuditsPanel.js:320 >> + ruleResultCallback(result); > > Have you made sure none of the callbacks use "this"? There is only one callback and it is already bound to its issuer object, so applying here has no effect.
WebKit Review Bot
Comment 4 2012-10-26 02:06:50 PDT
Comment on attachment 170622 [details] Patch Clearing flags on attachment: 170622 Committed r132588: <http://trac.webkit.org/changeset/132588>
WebKit Review Bot
Comment 5 2012-10-26 02:06:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.