Bug 100333 – [V8] DOMDataStoreHandle serves no purpose and can be removed

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

[V8] DOMDataStoreHandle serves no purpose and can be removed

[Adam Barth]

Created attachment 170554 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 170554 [details]
Patch

LGTM.

[Eric Seidel (no email)]

Comment on attachment 170554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:89
> +            m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld));

is adoptPtr necessary for OwnPtrs?

[Adam Barth]

(In reply to comment #3)
> (From update of attachment 170554 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review
> 
> > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89
> > +            m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld));
> 
> is adoptPtr necessary for OwnPtrs?

Yes.  That's a result of the "strict OwnPtr" work from a year or so ago.

[WebKit Review Bot]

Comment on attachment 170554 [details]
Patch

Clearing flags on attachment: 170554

Committed r132458: <http://trac.webkit.org/changeset/132458>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.