Bug 100333

Summary: [V8] DOMDataStoreHandle serves no purpose and can be removed
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100316    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Adam Barth 2012-10-24 23:06:33 PDT
[V8] DOMDataStoreHandle serves no purpose and can be removed
Comment 1 Adam Barth 2012-10-24 23:07:17 PDT
Created attachment 170554 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-24 23:19:35 PDT
Comment on attachment 170554 [details]
Patch

LGTM.
Comment 3 Eric Seidel (no email) 2012-10-24 23:20:08 PDT
Comment on attachment 170554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:89
> +            m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld));

is adoptPtr necessary for OwnPtrs?
Comment 4 Adam Barth 2012-10-24 23:29:43 PDT
(In reply to comment #3)
> (From update of attachment 170554 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review
> 
> > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89
> > +            m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld));
> 
> is adoptPtr necessary for OwnPtrs?

Yes.  That's a result of the "strict OwnPtr" work from a year or so ago.
Comment 5 WebKit Review Bot 2012-10-25 01:15:15 PDT
Comment on attachment 170554 [details]
Patch

Clearing flags on attachment: 170554

Committed r132458: <http://trac.webkit.org/changeset/132458>
Comment 6 WebKit Review Bot 2012-10-25 01:15:19 PDT
All reviewed patches have been landed.  Closing bug.