Summary: | BlackBerry fix for webgl-depth-texture.html | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Feldstein <jfeldstein> | ||||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, fspacek, mifenton, staikos, webkit.review.bot, yong.li.webkit | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Other | ||||||||||
Attachments: |
|
Description
Jonathan Feldstein
2012-10-24 08:48:45 PDT
Created attachment 170425 [details]
Patch
Created attachment 170428 [details]
Patch
Comment on attachment 170428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review > Source/WebCore/ChangeLog:11 > + > + No new tests (OOPS!). > + Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121 > -#if !PLATFORM(BLACKBERRY) > case GraphicsContext3D::UNSIGNED_INT_24_8: > -#endif any idea about why we did this before? (In reply to comment #3) > (From update of attachment 170428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review > > > Source/WebCore/ChangeLog:11 > > + > > + No new tests (OOPS!). > > + > > Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed > > > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121 > > -#if !PLATFORM(BLACKBERRY) > > case GraphicsContext3D::UNSIGNED_INT_24_8: > > -#endif > > any idea about why we did this before? I spoke with a few other people and no one came up with a good reason. Worst case instead of returning false we'd eventually cause a gl error for an invalid enum. Not that that should happen anyways. I'll add you as the reviewer at the same time as removing the no new tests line. Created attachment 170444 [details]
Patch
Comment on attachment 170444 [details]
Patch
seems this code was added for build fix... so I assume we can build with UNSIGNED_INT_24_8 now.
Comment on attachment 170444 [details] Patch Clearing flags on attachment: 170444 Committed r132387: <http://trac.webkit.org/changeset/132387> All reviewed patches have been landed. Closing bug. |