Bug 100258

Summary: BlackBerry fix for webgl-depth-texture.html
Product: WebKit Reporter: Jonathan Feldstein <jfeldstein>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, fspacek, mifenton, staikos, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Feldstein
Reported 2012-10-24 08:48:45 PDT
webgl-depth-texture.html is a WebGL conformance suite test that is partially failing on the BlackBerry platform. We need to upstream a fix for this.
Attachments
Patch (753 bytes, patch)
2012-10-24 10:31 PDT, Jonathan Feldstein 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2012-10-24 10:50 PDT, Jonathan Feldstein 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2012-10-24 12:15 PDT, Jonathan Feldstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Feldstein
Comment 1 2012-10-24 10:31:47 PDT
Created attachment 170425 [details] Patch
Jonathan Feldstein
Comment 2 2012-10-24 10:50:51 PDT
Created attachment 170428 [details] Patch
Yong Li
Comment 3 2012-10-24 11:57:45 PDT
Comment on attachment 170428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review > Source/WebCore/ChangeLog:11 > + > + No new tests (OOPS!). > + Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121 > -#if !PLATFORM(BLACKBERRY) > case GraphicsContext3D::UNSIGNED_INT_24_8: > -#endif any idea about why we did this before?
Jonathan Feldstein
Comment 4 2012-10-24 12:10:54 PDT
(In reply to comment #3) > (From update of attachment 170428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review > > > Source/WebCore/ChangeLog:11 > > + > > + No new tests (OOPS!). > > + > > Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed > > > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121 > > -#if !PLATFORM(BLACKBERRY) > > case GraphicsContext3D::UNSIGNED_INT_24_8: > > -#endif > > any idea about why we did this before? I spoke with a few other people and no one came up with a good reason. Worst case instead of returning false we'd eventually cause a gl error for an invalid enum. Not that that should happen anyways. I'll add you as the reviewer at the same time as removing the no new tests line.
Jonathan Feldstein
Comment 5 2012-10-24 12:15:09 PDT
Created attachment 170444 [details] Patch
Yong Li
Comment 6 2012-10-24 12:51:53 PDT
Comment on attachment 170444 [details] Patch seems this code was added for build fix... so I assume we can build with UNSIGNED_INT_24_8 now.
WebKit Review Bot
Comment 7 2012-10-24 13:16:09 PDT
Comment on attachment 170444 [details] Patch Clearing flags on attachment: 170444 Committed r132387: <http://trac.webkit.org/changeset/132387>
WebKit Review Bot
Comment 8 2012-10-24 13:16:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.