Bug 100231

Summary: CSS3 Media Queries - add resolution tests to W3C test suite
Product: WebKit Reporter: Alexander Shalamov <alexander.shalamov>
Component: CSSAssignee: Alexander Shalamov <alexander.shalamov>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, feature-media-reviews, kenneth, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78087    
Attachments:
Description Flags
Patch 1
kenneth: review+, webkit.review.bot: commit-queue-
Patch 2 none

Alexander Shalamov
Reported 2012-10-24 04:38:49 PDT
Resolution tests were removed, since implementation was missing. Since resolution feature was added recently, tests could be added back.
Attachments
Patch 1 (4.77 KB, patch)
2012-10-24 04:48 PDT, Alexander Shalamov 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch 2 (93.20 KB, patch)
2012-10-24 07:03 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Shalamov
Comment 1 2012-10-24 04:48:22 PDT
Created attachment 170365 [details] Patch 1 - Added resolution media feature tests to W3C Media Queries test suite
Kenneth Rohde Christiansen
Comment 2 2012-10-24 04:59:13 PDT
Comment on attachment 170365 [details] Patch 1 Not all platforms will pass with this and they will need different results. How do you intent to rebase that? After this lands?
WebKit Review Bot
Comment 3 2012-10-24 05:36:53 PDT
Comment on attachment 170365 [details] Patch 1 Attachment 170365 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14566184 New failing tests: fast/media/w3c/test_media_queries.html
Alexander Shalamov
Comment 4 2012-10-24 07:03:42 PDT
Created attachment 170389 [details] Patch 2 - Added platform specific test expectations to blackberry, chromium, mac, win and gtk ports - Added assert_false and assert_true wrappers, so that stack trace is not shown when the test is failed
WebKit Review Bot
Comment 5 2012-10-24 07:38:24 PDT
Comment on attachment 170389 [details] Patch 2 Clearing flags on attachment: 170389 Committed r132352: <http://trac.webkit.org/changeset/132352>
WebKit Review Bot
Comment 6 2012-10-24 07:38:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.