Summary: | CSS3 Media Queries - add resolution tests to W3C test suite | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Shalamov <alexander.shalamov> | ||||||
Component: | CSS | Assignee: | Alexander Shalamov <alexander.shalamov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, eric.carlson, feature-media-reviews, kenneth, mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 78087 | ||||||||
Attachments: |
|
Description
Alexander Shalamov
2012-10-24 04:38:49 PDT
Created attachment 170365 [details]
Patch 1
- Added resolution media feature tests to W3C Media Queries test suite
Comment on attachment 170365 [details]
Patch 1
Not all platforms will pass with this and they will need different results. How do you intent to rebase that? After this lands?
Comment on attachment 170365 [details] Patch 1 Attachment 170365 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14566184 New failing tests: fast/media/w3c/test_media_queries.html Created attachment 170389 [details]
Patch 2
- Added platform specific test expectations to blackberry, chromium, mac, win and gtk ports
- Added assert_false and assert_true wrappers, so that stack trace is not shown when the test is failed
Comment on attachment 170389 [details] Patch 2 Clearing flags on attachment: 170389 Committed r132352: <http://trac.webkit.org/changeset/132352> All reviewed patches have been landed. Closing bug. |