Bug 100183

Summary: encode should take an ArgumentEncoder reference
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gustavo, gyuyoung.kim, menard, philn, rakuco, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch jberlin: review+

Anders Carlsson
Reported 2012-10-23 19:56:10 PDT
encode should take an ArgumentEncoder reference
Attachments
Patch (107.43 KB, patch)
2012-10-23 20:00 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (108.18 KB, patch)
2012-10-23 20:11 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (135.93 KB, patch)
2012-10-23 20:26 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (136.14 KB, patch)
2012-10-23 20:54 PDT, Anders Carlsson 		jberlin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-23 20:00:26 PDT
Created attachment 170297 [details] Patch
Anders Carlsson
Comment 2 2012-10-23 20:11:12 PDT
Created attachment 170298 [details] Patch
Andreas Kling
Comment 3 2012-10-23 20:17:27 PDT
Comment on attachment 170298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170298&action=review rs=me > Source/WebKit2/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). OOPS!
EFL EWS Bot
Comment 4 2012-10-23 20:25:56 PDT
Comment on attachment 170298 [details] Patch Attachment 170298 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14562014
Anders Carlsson
Comment 5 2012-10-23 20:26:12 PDT
Created attachment 170299 [details] Patch
Andreas Kling
Comment 6 2012-10-23 20:36:02 PDT
Comment on attachment 170299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170299&action=review Rubberstamp still stands. > Source/WebKit2/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). OOPS!!!i1i!I!99q
WebKit Review Bot
Comment 7 2012-10-23 20:37:19 PDT
Attachment 170299 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/win/PlatformCertificateInfo.h:54: The parameter name "encoder" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 128 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 8 2012-10-23 20:40:32 PDT
Comment on attachment 170298 [details] Patch Attachment 170298 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14563026
Build Bot
Comment 9 2012-10-23 20:54:18 PDT
Comment on attachment 170299 [details] Patch Attachment 170299 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14563033
Anders Carlsson
Comment 10 2012-10-23 20:54:38 PDT
Created attachment 170304 [details] Patch
WebKit Review Bot
Comment 11 2012-10-23 20:57:21 PDT
Attachment 170304 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/win/PlatformCertificateInfo.h:54: The parameter name "encoder" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 128 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jessie Berlin
Comment 12 2012-10-24 08:37:21 PDT
Comment on attachment 170304 [details] Patch r=me assuming you fix the style error.
Anders Carlsson
Comment 13 2012-10-24 09:18:41 PDT
Committed r132361: <http://trac.webkit.org/changeset/132361>
Note You need to log in before you can comment on or make changes to this bug.