Bug 100171

Summary: [Mac] Sync up FeatureDefine Configuration Files
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ddkilzer, joepeck, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Patch
ddkilzer: review+, joepeck: commit-queue-
[PATCH] Follow-up For Better iOS Coordination ddkilzer: review+, joepeck: commit-queue-

Joseph Pecoraro
Reported 2012-10-23 16:18:17 PDT
Some features are enabled only in one of the project configurations files, etc. The files should be identical to avoid accidents and unexpected build issues. I'll follow with some patches.
Attachments
[PATCH] Proposed Patch (30.19 KB, patch)
2012-10-23 16:27 PDT, Joseph Pecoraro 		ddkilzer: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Follow-up For Better iOS Coordination (20.95 KB, patch)
2012-10-23 16:50 PDT, Joseph Pecoraro 		ddkilzer: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2012-10-23 16:27:40 PDT
Created attachment 170266 [details] [PATCH] Proposed Patch Make the configuration file identical across all projects.
Joseph Pecoraro
Comment 2 2012-10-23 16:50:50 PDT
Created attachment 170268 [details] [PATCH] Follow-up For Better iOS Coordination Some of these features are disabled for iOS but enabled for iOS. Make those _macosx only. And other cleanup. cq- on these because this one depends on the first landing, and I don't think the cq works well with multiple patches on a bug.
David Kilzer (:ddkilzer)
Comment 3 2012-10-26 11:08:36 PDT
Comment on attachment 170266 [details] [PATCH] Proposed Patch r=me
David Kilzer (:ddkilzer)
Comment 4 2012-10-26 11:09:57 PDT
Comment on attachment 170268 [details] [PATCH] Follow-up For Better iOS Coordination r=me
Joseph Pecoraro
Comment 5 2012-10-30 16:51:17 PDT
First part landed in r132958: <http://trac.webkit.org/changeset/132958> Second part landed in r132963: <http://trac.webkit.org/changeset/132963>
Note You need to log in before you can comment on or make changes to this bug.