Bug 100129

Summary:

Move appendAsLDMLLiteral in LocaleWin.cpp to a common place

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Platform

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

haraken, yutak

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

100128

Attachments:

Description	Flags
Patch	haraken: review+

Description Kent Tamura 2012-10-23 08:49:20 PDT

Move appendAsLDMLLiteral in LocaleWin.cpp to a common place

Comment 1 Kent Tamura 2012-10-23 08:54:24 PDT

Created attachment 170174 [details]
Patch

Comment 2 Kentaro Hara 2012-10-23 08:58:34 PDT

Comment on attachment 170174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170174&action=review

OK

> Source/WebCore/ChangeLog:9
> +        related to DateTimeFormat class.  So we move it to DateTimeForma

Typo: DateTimeForma => DateTimeFormat.

> Source/WebCore/ChangeLog:10
> +        class as quoteAndAppendLiteral.

Nit: I would slightly prefer appendLiteralAndQuote(). (It's up to you.)

Comment 3 Kent Tamura 2012-10-23 19:17:08 PDT

Committed r132292: <http://trac.webkit.org/changeset/132292>