Bug 100129 - Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
Summary: Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 100128
  Show dependency tree / graph
 
Reported: 2012-10-23 08:49 PDT by Kent Tamura
Modified: 2012-10-23 19:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2012-10-23 08:54 PDT, Kent Tamura 		haraken: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-23 08:49:20 PDT 
Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
Comment 1 Kent Tamura 2012-10-23 08:54:24 PDT 
Created attachment 170174 [details]
Patch
Comment 2 Kentaro Hara 2012-10-23 08:58:34 PDT 
Comment on attachment 170174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170174&action=review

OK

> Source/WebCore/ChangeLog:9
> +        related to DateTimeFormat class.  So we move it to DateTimeForma

Typo: DateTimeForma => DateTimeFormat.

> Source/WebCore/ChangeLog:10
> +        class as quoteAndAppendLiteral.

Nit: I would slightly prefer appendLiteralAndQuote(). (It's up to you.)
Comment 3 Kent Tamura 2012-10-23 19:17:08 PDT 
Committed r132292: <http://trac.webkit.org/changeset/132292>