Bug 100115

Summary: [Qt] Text with zero font size renders as X px sometimes, causing fast/text/zero-font-size-2.html to fail
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ggaren, mitz, noam, ossy, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87008, 99918    
Attachments:
Description Flags
copy/paste fix
none
patch none

Csaba Osztrogonác
Reported 2012-10-23 06:22:33 PDT
fast/text/zero-font-size-2.html intoduced in https://trac.webkit.org/changeset/131995 and fails on Qt, because r131995 fixed the bug for Mac only. diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r132209%20%2844199%29/fast/text/zero-font-size-2-diffs.html Original bug: https://bugs.webkit.org/show_bug.cgi?id=99918 Similar Chomium bug: https://bugs.webkit.org/show_bug.cgi?id=99920
Attachments
copy/paste fix (1.27 KB, patch)
2012-10-23 06:27 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (2.85 KB, patch)
2012-10-23 07:17 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-10-23 06:27:26 PDT
Created attachment 170143 [details] copy/paste fix I don't know anything about font handling, but copy/pasting the code from https://bugs.webkit.org/show_bug.cgi?id=100115 fixed this test. (And it didn't cause new layout test failures of course.)
WebKit Review Bot
Comment 2 2012-10-23 06:34:31 PDT
Comment on attachment 170143 [details] copy/paste fix Attachment 170143 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14482970
Csaba Osztrogonác
Comment 3 2012-10-23 06:36:16 PDT
Comment on attachment 170143 [details] copy/paste fix CQ again, chromium EWS is buggy.
Csaba Osztrogonác
Comment 4 2012-10-23 07:17:06 PDT
Created attachment 170158 [details] patch
Csaba Osztrogonác
Comment 5 2012-10-25 03:42:03 PDT
ping?
Csaba Osztrogonác
Comment 6 2012-10-29 07:37:31 PDT
ping?
WebKit Review Bot
Comment 7 2012-10-29 07:47:54 PDT
Comment on attachment 170158 [details] patch Clearing flags on attachment: 170158 Committed r132802: <http://trac.webkit.org/changeset/132802>
WebKit Review Bot
Comment 8 2012-10-29 07:47:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.