Bug 100095 – Web Inspector: Console message's anchor element should be trimmed for readability.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Mike West]

Looooong URLs used as the anchor for console messages (e.g. a call stack link) can overflow the width of the window. They should be trimmed.

Attached is an example of the issue.

[Mike West]

Created attachment 170091 [details]
Image of looooong anchor elements.

[Mike West]

Created attachment 175976 [details]
Before the patch.

[Mike West]

Created attachment 175977 [details]
After the patch.

[Mike West]

Created attachment 175978 [details]
Patch

[WebKit Review Bot]

Comment on attachment 175978 [details]
Patch

Attachment 175978 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14983666

New failing tests:
http/tests/inspector/network/script-as-text-loading-long-url.html
fast/text/atsui-small-caps-punctuation-size.html

[Mike West]

Created attachment 175997 [details]
Fixing V8 expectation.

[Mike West]

(In reply to comment #5)
> (From update of attachment 175978 [details])
> Attachment 175978 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/14983666
> 
> New failing tests:
> http/tests/inspector/network/script-as-text-loading-long-url.html
> fast/text/atsui-small-caps-punctuation-size.html

1. I commented out the critical bit of code to generate the "before" screenshot. I left it in when I uploaded the patch. I am an idiot. :)
2. I needed to have a platform-specific result here, so it wouldn't have worked anyway.

Latest patch should fix the issues.

[Build Bot]

Comment on attachment 175997 [details]
Fixing V8 expectation.

Attachment 175997 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14984870

New failing tests:
http/tests/inspector/network/script-as-text-loading-long-url.html

[Mike West]

Created attachment 176202 [details]
Patch

[Mike West]

(In reply to comment #9)
> Created an attachment (id=176202) [details]
> Patch

Friendly ping. Any inspector folks interested in picking this up? :)

[Pavel Feldman]

Comment on attachment 176202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176202&action=review

Please fix the nit prior to landing.

> Source/WebCore/inspector/front-end/inspector.js:997
> +WebInspector.MaxLengthForDisplayedURLs = 150;

inspectot.js is currently not compiled - it depends from the universe. We should declare constants in common places instead. Such as WebInspector.Linkifier.MaxLengthForDisplayedURLs

[Mike West]

Created attachment 176508 [details]
Patch

[WebKit Review Bot]

Comment on attachment 176508 [details]
Patch

Clearing flags on attachment: 176508

Committed r136104: <http://trac.webkit.org/changeset/136104>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.