Bug 100090

Summary: Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

eustas.bug
Reported 2012-10-23 01:34:50 PDT
Script "check-inspector-strings" seems to be broken. Fixed it, refined search algorithm, introduced "/* LOCALIZED */" marker.
Attachments
Patch (27.95 KB, patch)
2012-10-23 01:59 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (27.96 KB, patch)
2012-10-23 02:46 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (27.26 KB, patch)
2012-10-23 04:55 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (11.74 KB, patch)
2012-10-24 02:15 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-10-23 01:59:32 PDT
Created attachment 170085 [details] Patch
WebKit Review Bot
Comment 2 2012-10-23 02:02:55 PDT
Attachment 170085 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
eustas.bug
Comment 3 2012-10-23 02:46:41 PDT
Created attachment 170099 [details] Patch fixed-cl-entry
eustas.bug
Comment 4 2012-10-23 04:55:37 PDT
Created attachment 170125 [details] Patch rebased
Vsevolod Vlasov
Comment 5 2012-10-23 09:18:43 PDT
I would not land this LOCALIZED comments part. I don't think they introduce any clear immediate value while making the code look UGLY.
eustas.bug
Comment 6 2012-10-24 02:15:03 PDT
Created attachment 170345 [details] Patch
WebKit Review Bot
Comment 7 2012-10-25 00:32:49 PDT
Comment on attachment 170345 [details] Patch Clearing flags on attachment: 170345 Committed r132455: <http://trac.webkit.org/changeset/132455>
WebKit Review Bot
Comment 8 2012-10-25 00:32:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.