Bug 100080

Summary: Web Inspector: ReferenceError: Can't find variable: bottom
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change
none
Patch vsevik: review-

Timothy Hatcher
Reported 2012-10-22 23:25:08 PDT
ReferenceError: Can't find variable: bottom evaluateOnLoad(String::format("[\"setDockSide\", %s]", attached ? "bottom" : "undocked")); the %s needs quotes. caused by bug 99717
Attachments
Proposed Change (2.23 KB, patch)
2012-10-22 23:31 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2012-10-23 09:29 PDT, Pavel Feldman 		vsevik: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-10-22 23:31:15 PDT
Created attachment 170069 [details] Proposed Change
WebKit Review Bot
Comment 2 2012-10-23 00:54:05 PDT
Comment on attachment 170069 [details] Proposed Change Clearing flags on attachment: 170069 Committed r132185: <http://trac.webkit.org/changeset/132185>
WebKit Review Bot
Comment 3 2012-10-23 00:54:09 PDT
All reviewed patches have been landed. Closing bug.
Pavel Feldman
Comment 4 2012-10-23 09:28:59 PDT
Reopening to attach new patch.
Pavel Feldman
Comment 5 2012-10-23 09:29:03 PDT
Created attachment 170182 [details] Patch
Vsevolod Vlasov
Comment 6 2012-10-23 09:33:37 PDT
Comment on attachment 170182 [details] Patch This is already landed :)
Pavel Feldman
Comment 7 2012-10-23 09:34:33 PDT
Sorry, I just found console with webkit-patch upload pending and hit Enter :)
Note You need to log in before you can comment on or make changes to this bug.