Bug 100043

Summary: Don't include individual strategy headers
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED WONTFIX    
Severity: Normal CC: allan.jensen, andersca, beidson, cmarcelo, danw, gustavo, japhet, macpherson, menard, mifenton, mrobinson, philn, rakuco, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100031    
Bug Blocks:    
Attachments:
Description Flags
proposed patch beidson: review+, webkit-ews: commit-queue-

Alexey Proskuryakov
Reported 2012-10-22 15:56:47 PDT
Now that PlatformStrategies.h has them all.
Attachments
proposed patch (5.90 KB, patch)
2012-10-22 15:59 PDT, Alexey Proskuryakov 		beidson: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-10-22 15:59:08 PDT
Created attachment 170010 [details] proposed patch EWS will bark, because this depends on bug 100031.
Early Warning System Bot
Comment 2 2012-10-22 16:02:15 PDT
Comment on attachment 170010 [details] proposed patch Attachment 170010 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14496431
Early Warning System Bot
Comment 3 2012-10-22 16:04:04 PDT
Comment on attachment 170010 [details] proposed patch Attachment 170010 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14481732
Brady Eidson
Comment 4 2012-10-22 16:15:00 PDT
Comment on attachment 170010 [details] proposed patch I understand this patch relies on 100031 and that's why EWSs are failing. It seems straightforward enough to r+ anyways, trusting that you'll watch things when you land.
Build Bot
Comment 5 2012-10-22 16:16:37 PDT
Comment on attachment 170010 [details] proposed patch Attachment 170010 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14488605
EFL EWS Bot
Comment 6 2012-10-22 16:24:21 PDT
Comment on attachment 170010 [details] proposed patch Attachment 170010 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14499355
Build Bot
Comment 7 2012-10-22 16:25:04 PDT
Comment on attachment 170010 [details] proposed patch Attachment 170010 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14483695
Alexey Proskuryakov
Comment 8 2012-10-22 16:58:26 PDT
Depends on a flawed refactoring.
Note You need to log in before you can comment on or make changes to this bug.