Bug 100013 – [chromium] Expose setAutomaticallyComputeRasterScale on the WebLayer API

• Component: New Bugs
• Status: RESOLVED FIXED

[Dana Jansens]

[chromium] Expose setInitialCssScale on the WebLayer API

[Dana Jansens]

Created attachment 169937 [details]
Patch

[Dana Jansens]

This depends on https://codereview.chromium.org/11227031/ and blocks relanding https://codereview.chromium.org/10915313

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 169937 [details]
Patch

Attachment 169937 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14486577

[Peter Beverloo (cr-android ews)]

Comment on attachment 169937 [details]
Patch

Attachment 169937 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14489580

[Dana Jansens]

Created attachment 169960 [details]
Patch

[Dana Jansens]

updated to opt-in

[Adrienne Walker]

Comment on attachment 169960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169960&action=review

> Source/Platform/chromium/public/WebLayer.h:108
> +    virtual void setAutomaticallyComputeRasterScale(bool) = 0;

I feel like this is more of a WebContentLayer concern than a general WebLayer one.

[WebKit Review Bot]

Comment on attachment 169960 [details]
Patch

Attachment 169960 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14514001

[Peter Beverloo (cr-android ews)]

Comment on attachment 169960 [details]
Patch

Attachment 169960 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14516001

[Dana Jansens]

Created attachment 169965 [details]
Patch

Moved to WebContentLayer

[WebKit Review Bot]

Comment on attachment 169965 [details]
Patch

Attachment 169965 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14487555

[Peter Beverloo (cr-android ews)]

Comment on attachment 169965 [details]
Patch

Attachment 169965 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14496378

[James Robinson]

Comment on attachment 169965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review

> Source/Platform/chromium/public/WebContentLayer.h:54
> +    virtual void setAutomaticallyComputeRasterScale(bool) = 0;

If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. 

Please document the default (false, I presume)

[Dana Jansens]

Comment on attachment 169965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review

>> Source/Platform/chromium/public/WebContentLayer.h:54
>> +    virtual void setAutomaticallyComputeRasterScale(bool) = 0;
> 
> If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. 
> 
> Please document the default (false, I presume)

Oh, sure. 2 patches instead of 1. Or will I need to come back here and remove the default implementation after?

False, yep. k.

[James Robinson]

(In reply to comment #15)
> (From update of attachment 169965 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review
> 
> >> Source/Platform/chromium/public/WebContentLayer.h:54
> >> +    virtual void setAutomaticallyComputeRasterScale(bool) = 0;
> > 
> > If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. 
> > 
> > Please document the default (false, I presume)
> 
> Oh, sure. 2 patches instead of 1. Or will I need to come back here and remove the default implementation after?

Wouldn't necessarily need to. It'd be good to be consistent, but might be better to just have all of these have default impls to make changing other APIs easier as well.  Even if you did you wouldn't have to worry about synchronizing it with anything else.

[Dana Jansens]

Created attachment 170008 [details]
Patch

Default impl and document return value

[WebKit Review Bot]

Comment on attachment 170008 [details]
Patch

Clearing flags on attachment: 170008

Committed r132223: <http://trac.webkit.org/changeset/132223>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.