Summary: | [Gtk] The accessible hierarchy of tables is significantly incorrect for Atk | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apinheiro, commit-queue, eric, walker.willie, xan.lopez | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 25531, 35504 | ||||||||
Attachments: |
|
Description
Joanmarie Diggs
2009-10-28 22:07:09 PDT
Created attachment 49704 [details] proposed fix - includes layout test It turns out that the fix for bug 35418 also unborked the accessible table hierarchy somewhat. This patch seems to finish the job. Drat! There are still other cases of borked tables. The previous patch changes are necessary, but additional changes will be as well. (I knew it seemed too easy....) :-( Created attachment 49730 [details]
rest of the fix - includes additional layout test
The other issue turned out to be that any table identified as an AccessibilityTable always added a bunch of children without considering whether or not those children should be "ignored" by the platform. This patch changes that so an AccessibilityTable only adds children that are not "ignored." It also makes corresponding Gtk-specific changes so that we can actually specify that they should be ignored.
Note that this patch assumes/depends upon the previous one. Therefore, I'm not yet flagging it for review as the bots will just spit up on it. But as far as I'm concerned at the moment, this is everything that needs to be done w.r.t. this bug pending code review.
Comment on attachment 49704 [details]
proposed fix - includes layout test
OK.
Is the second patch supposed to be marked for review? Comment on attachment 49730 [details]
rest of the fix - includes additional layout test
I assume the bots will spit up on this one (seeing as how the first one is still in the commit queue and this patch assumes the first). But having said that, a review would be lovely. Thanks for asking, Eric.
Comment on attachment 49704 [details] proposed fix - includes layout test Clearing flags on attachment: 49704 Committed r55623: <http://trac.webkit.org/changeset/55623> Comment on attachment 49730 [details]
rest of the fix - includes additional layout test
Looks good to me.
Comment on attachment 49730 [details] rest of the fix - includes additional layout test Clearing flags on attachment: 49730 Committed r55680: <http://trac.webkit.org/changeset/55680> All reviewed patches have been landed. Closing bug. |