Attachment 83734 Details for Bug 55190 – Patch

[patch] Patch

bug-55190-20110224153905.patch (text/plain), 1.38 KB, created by Anders Carlsson on 2011-02-24 15:39:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Anders Carlsson

Created: 2011-02-24 15:39:06 PST

Size: 1.38 KB

patch

obsolete

>Index: Source/WebKit2/ChangeLog
>===================================================================
>--- Source/WebKit2/ChangeLog	(revision 79632)
>+++ Source/WebKit2/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2011-02-24  Anders Carlsson  <andersca@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Crash when trying to send a sync message on an invalid connection
>+        https://bugs.webkit.org/show_bug.cgi?id=55190
>+        <rdar://problem/9035806>
>+
>+        * Platform/CoreIPC/Connection.cpp:
>+        (CoreIPC::Connection::sendSyncMessage):
>+        Don't try to call a client function is isValid() returns false since the client
>+        will be null in that case.
>+
> 2011-02-24  Anders Carlsson  <andersca@apple.com>
> 
>         Reviewed by Dan Bernstein.
>Index: Source/WebKit2/Platform/CoreIPC/Connection.cpp
>===================================================================
>--- Source/WebKit2/Platform/CoreIPC/Connection.cpp	(revision 79629)
>+++ Source/WebKit2/Platform/CoreIPC/Connection.cpp	(working copy)
>@@ -343,10 +343,8 @@ PassOwnPtr<ArgumentDecoder> Connection::
>     // We only allow sending sync messages from the client run loop.
>     ASSERT(RunLoop::current() == m_clientRunLoop);
> 
>-    if (!isValid()) {
>-        m_client->didFailToSendSyncMessage(this);
>+    if (!isValid())
>         return 0;
>-    }
>     
>     // Push the pending sync reply information on our stack.
>     {

Flags:

mitz: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 55190: 83734