Attachment 63536 Details for Bug 43534 – (committed with r64705, r=daniel bates) patch v1

[patch] (committed with r64705, r=daniel bates) patch v1

0001-2010-08-04-Antonio-Gomes-tonikitoo-webkit.org.patch (text/plain), 2.97 KB, created by Antonio Gomes on 2010-08-04 19:55:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antonio Gomes

Created: 2010-08-04 19:55:25 PDT

Size: 2.97 KB

patch

obsolete

>From 511bc5bce3c5ca9851a2e4e92f9683302d021937 Mon Sep 17 00:00:00 2001
>From: Antonio Gomes <tonikitoo@webkit.org>
>Date: Wed, 4 Aug 2010 22:53:07 -0400
>Subject: [PATCH] 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
>
>        Reviewed by NOBODY (OOPS!).
>
>        Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
>        https://bugs.webkit.org/show_bug.cgi?id=43534
>
>        As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
>        the non-negative checks present in both paddingWidth and paddingHeight methods of
>        HitTestResults class are superflous, after we changed the rect based hit testing logic
>        of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.
>
>        No new tests needed.
>
>        * rendering/HitTestResult.h:
>        (WebCore::HitTestResult::paddingWidth):
>        (WebCore::HitTestResult::paddingHeight):
>---
> WebCore/ChangeLog                 |   18 ++++++++++++++++++
> WebCore/rendering/HitTestResult.h |    4 ++--
> 2 files changed, 20 insertions(+), 2 deletions(-)
>
>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>index 365662c..db5dfb3 100644
>--- a/WebCore/ChangeLog
>+++ b/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
>+        https://bugs.webkit.org/show_bug.cgi?id=43534
>+
>+        As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
>+        the non-negative checks present in both paddingWidth and paddingHeight methods of
>+        HitTestResults class are superflous, after we changed the rect based hit testing logic
>+        of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.
>+
>+        No new tests needed.
>+
>+        * rendering/HitTestResult.h:
>+        (WebCore::HitTestResult::paddingWidth):
>+        (WebCore::HitTestResult::paddingHeight):
>+
> 2010-08-04  Gavin Barraclough  <barraclough@apple.com>
> 
>         Reviewed by Sam Weinig.
>diff --git a/WebCore/rendering/HitTestResult.h b/WebCore/rendering/HitTestResult.h
>index f47e2a5..e0ffe54 100644
>--- a/WebCore/rendering/HitTestResult.h
>+++ b/WebCore/rendering/HitTestResult.h
>@@ -86,8 +86,8 @@ public:
>     IntRect rectFromPoint(int x, int y) const;
>     IntRect rectFromPoint(const IntPoint&) const;
>     IntSize padding() const { return m_padding; }
>-    int paddingWidth() const { return m_padding.width() >= 0 ? m_padding.width() : 0; }
>-    int paddingHeight() const { return m_padding.height() >= 0 ? m_padding.height() : 0; }
>+    int paddingWidth() const { return m_padding.width(); }
>+    int paddingHeight() const { return m_padding.height(); }
>     // Returns true if it is rect-based hit test and needs to continue until the rect is fully
>     // enclosed by the boundaries of a node.
>     bool addNodeToRectBasedTestResult(Node*, int x, int y, const IntRect& rect = IntRect());
>-- 
>1.7.0.4
>

Actions: View | Formatted Diff | Diff

Attachments on bug 43534: 63536