Attachment 63341 Details for Bug 43429 – proposed patch

[patch] proposed patch

0001-Highlight-nodes-for-the-inspector.patch (text/plain), 2.67 KB, created by Gustavo Noronha (kov) on 2010-08-03 09:42:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Gustavo Noronha (kov)

Created: 2010-08-03 09:42:38 PDT

Size: 2.67 KB

patch

obsolete

>From 2f2ee094ac11944e14012ed88381615040e69013 Mon Sep 17 00:00:00 2001
>From: Gustavo Noronha Silva <gns@gnome.org>
>Date: Tue, 3 Aug 2010 13:29:45 -0300
>Subject: [PATCH] Highlight nodes for the inspector
>
>---
> WebKit/gtk/ChangeLog                             |   15 +++++++++++++++
> WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp |   10 +++++++---
> WebKit/gtk/webkit/webkitwebview.cpp              |    5 +++++
> 3 files changed, 27 insertions(+), 3 deletions(-)
>
>diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
>index bf1777d..19e27f5 100644
>--- a/WebKit/gtk/ChangeLog
>+++ b/WebKit/gtk/ChangeLog
>@@ -1,3 +1,18 @@
>+2010-08-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [GTK] Does not paint the node highlight used by the inspector
>+        https://bugs.webkit.org/show_bug.cgi?id=43429
>+
>+        Implement highlighting the nodes when using the inspector.
>+
>+        * WebCoreSupport/InspectorClientGtk.cpp:
>+        (WebKit::InspectorClient::highlight):
>+        (WebKit::InspectorClient::hideHighlight):
>+        * webkit/webkitwebview.cpp:
>+        (webkit_web_view_expose_event):
>+
> 2010-07-26  Steve Block  <steveblock@google.com>
> 
>         Reviewed by Jeremy Orlow.
>diff --git a/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp b/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
>index 616834b..7039dd6 100644
>--- a/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
>+++ b/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
>@@ -101,14 +101,18 @@ void InspectorClient::releaseFrontendPage()
>     m_frontendPage = 0;
> }
> 
>-void InspectorClient::highlight(Node* node)
>+void InspectorClient::highlight(Node*)
> {
>-    notImplemented();
>+    hideHighlight();
> }
> 
> void InspectorClient::hideHighlight()
> {
>-    notImplemented();
>+    // FIXME: we should be able to only invalidate the actual rects of
>+    // the new and old nodes. We need to track the nodes, and take the
>+    // actual highlight size into account when calculating the damage
>+    // rect.
>+    gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
> }
> 
> void InspectorClient::populateSetting(const String& key, String* value)
>diff --git a/WebKit/gtk/webkit/webkitwebview.cpp b/WebKit/gtk/webkit/webkitwebview.cpp
>index cde9148..538b1b7 100644
>--- a/WebKit/gtk/webkit/webkitwebview.cpp
>+++ b/WebKit/gtk/webkit/webkitwebview.cpp
>@@ -548,6 +548,11 @@ static gboolean webkit_web_view_expose_event(GtkWidget* widget, GdkEventExpose*
>                 ctx.restore();
>             }
>         }
>+
>+        ctx.save();
>+        ctx.clip(static_cast<IntRect>(event->area));
>+        frame->page()->inspectorController()->drawNodeHighlight(ctx);
>+        ctx.restore();
>     }
> 
>     return FALSE;
>-- 
>1.7.1
>

Actions: View | Formatted Diff | Diff

Attachments on bug 43429: 63341