Attachment 416538 Details for Bug 220014 – Patch

[patch] Patch

bug-220014-20201218205205.patch (text/plain), 6.42 KB, created by Per Arne Vollan on 2020-12-18 11:52:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2020-12-18 11:52:07 PST

Size: 6.42 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 270968)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2020-12-18  Per Arne Vollan  <pvollan@apple.com>
>+
>+        [macOS] Deny mach lookup access to "com.apple.iconservices.store" in the WebContent process
>+        https://bugs.webkit.org/show_bug.cgi?id=220014
>+        <rdar://problem/68923110>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Deny mach lookup access to "com.apple.iconservices.store" in the WebContent process on macOS,
>+        since there are no longer any reports of this being used.
>+
>+        Test: fast/sandbox/mac/sandbox-mach-lookup.html
>+
>+        * WebProcess/com.apple.WebProcess.sb.in:
>+
> 2020-12-17  Kimmo Kinnunen  <kkinnunen@apple.com>
> 
>         REGRESSION (r268386): Snapshots of WebGL content in the tab picker don't work (black map on Google Maps)
>Index: Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>===================================================================
>--- Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	(revision 270932)
>+++ Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	(working copy)
>@@ -989,7 +989,6 @@
>     (global-name "com.apple.coreservices.launchservicesd")
> #endif
>     (global-name "com.apple.iconservices")
>-    (global-name "com.apple.iconservices.store")
>     (global-name "com.apple.tccd.system")
>     (global-name "com.apple.trustd.agent")
> )
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 270985)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2020-12-18  Per Arne Vollan  <pvollan@apple.com>
>+
>+        [macOS] Deny mach-lookup to the service 'com.apple.iconservices.store' in the WebContent process
>+        https://bugs.webkit.org/show_bug.cgi?id=220014
>+        <rdar://problem/68923110>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
>+        * fast/sandbox/mac/sandbox-mach-lookup.html:
>+        * platform/mac-catalina/fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
>+        * platform/mac-mojave/fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
>+
> 2020-12-18  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         [Mojave] webanimations/accelerated-transform-related-animation-property-order.html is failing
>Index: LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt
>===================================================================
>--- LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt	(revision 270932)
>+++ LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt	(working copy)
>@@ -12,5 +12,6 @@ PASS internals.hasSandboxMachLookupAcces
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.awdd") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.audio.SystemSoundServer-OSX") is false
>+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iconservices.store") is false
> PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.PerformanceAnalysis.animationperfd") is false
> 
>Index: LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html
>===================================================================
>--- LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html	(revision 270932)
>+++ LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html	(working copy)
>@@ -15,6 +15,7 @@ if (window.internals) {
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.awdd\")");
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.cookied\")");
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.audio.SystemSoundServer-OSX\")");
>+    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.iconservices.store\")");
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToXPCServiceName(\"com.apple.WebKit.WebContent\", \"com.apple.PerformanceAnalysis.animationperfd\")");
> }
> </script>
>Index: LayoutTests/platform/mac-catalina/fast/sandbox/mac/sandbox-mach-lookup-expected.txt
>===================================================================
>--- LayoutTests/platform/mac-catalina/fast/sandbox/mac/sandbox-mach-lookup-expected.txt	(revision 270932)
>+++ LayoutTests/platform/mac-catalina/fast/sandbox/mac/sandbox-mach-lookup-expected.txt	(working copy)
>@@ -12,5 +12,6 @@ PASS internals.hasSandboxMachLookupAcces
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.awdd") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.audio.SystemSoundServer-OSX") is false
>+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iconservices.store") is false
> PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.PerformanceAnalysis.animationperfd") is false
> 
>Index: LayoutTests/platform/mac-mojave/fast/sandbox/mac/sandbox-mach-lookup-expected.txt
>===================================================================
>--- LayoutTests/platform/mac-mojave/fast/sandbox/mac/sandbox-mach-lookup-expected.txt	(revision 270932)
>+++ LayoutTests/platform/mac-mojave/fast/sandbox/mac/sandbox-mach-lookup-expected.txt	(working copy)
>@@ -12,5 +12,6 @@ PASS internals.hasSandboxMachLookupAcces
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.awdd") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.audio.SystemSoundServer-OSX") is false
>+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iconservices.store") is false
> PASS internals.hasSandboxMachLookupAccessToXPCServiceName("com.apple.WebKit.WebContent", "com.apple.PerformanceAnalysis.animationperfd") is false
>

Actions: View | Formatted Diff | Diff

Attachments on bug 220014: 416515 | 416538