Attachment 413860 Details for Bug 218820 – Patch

[patch] Patch

218820.patch (text/plain), 3.08 KB, created by Per Arne Vollan on 2020-11-11 13:40:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2020-11-11 13:40:07 PST

Size: 3.08 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 269700)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2020-11-11  Per Arne Vollan  <pvollan@apple.com>
>+
>+        [iOS] IOKit sandbox violation when enabling all GPU runtime flags
>+        https://bugs.webkit.org/show_bug.cgi?id=218820
>+        <rdar://problem/71296116>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient
>+        in the WebContent process. When all GPU runtime flags are enabled, IOKit extensions are not provided to the WebContent process,
>+        which should then fall back to a set of rules allowing use of these IOKit classes, with logging. There seems to be a problem
>+        with the fallback for this specific IOKit class, which this patch addresses by adding an extra requirement to the rule. The
>+        extra requirement is that IOKit extensions have not been provided for these IOKit classes.
>+
>+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
>+
> 2020-11-11  Alex Christensen  <achristensen@webkit.org>
> 
>         Define USE(LEGACY_CFNETWORK_DOWNLOADS)
>Index: Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>===================================================================
>--- Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	(revision 269596)
>+++ Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	(working copy)
>@@ -472,18 +472,6 @@
> (with-filter (system-attribute apple-internal)
>   (mobile-preferences-read "com.apple.PrototypeTools"))
> 
>-(allow iokit-open (with report) (with telemetry-backtrace)
>-    (iokit-user-client-class "IOMobileFramebufferUserClient")
>-    (iokit-user-client-class "AGXDeviceUserClient")
>-    (iokit-user-client-class "AppleJPEGDriverUserClient")
>-    (iokit-user-client-class "IOSurfaceAcceleratorClient")
>-    (iokit-user-client-class "IOSurfaceRootUserClient")
>-)
>-
>-(allow iokit-open (with report) (with telemetry-backtrace)
>-    (iokit-connection "IOGPU")
>-)
>-
> (with-elevated-precedence
>     (allow file-read*
>            (subpath "/usr/lib"
>@@ -983,6 +971,27 @@
>     (global-name "com.apple.mobilegestalt.xpc")
> )
> 
>+;; FIXME: This is just for logging. Remove when the GPU process is enabled by default.
>+(allow iokit-open (with report) (with telemetry-backtrace)
>+    (require-all
>+        (require-not (extension "com.apple.webkit.extension.iokit"))
>+        (iokit-user-client-class
>+            "IOMobileFramebufferUserClient"
>+            "AGXDeviceUserClient"
>+            "AppleJPEGDriverUserClient"
>+            "IOSurfaceAcceleratorClient"
>+            "IOSurfaceRootUserClient"
>+        )
>+    )
>+)
>+
>+(allow iokit-open (with report) (with telemetry-backtrace)
>+    (require-all
>+        (require-not (extension "com.apple.webkit.extension.iokit"))
>+        (iokit-connection "IOGPU")
>+    )
>+)
>+
> (allow mach-lookup
>     (require-all
>         (extension "com.apple.webkit.extension.mach")

Actions: View | Formatted Diff | Diff

Attachments on bug 218820: 413859 | 413860