Attachment 390979 Details for Bug 207860 – Patch

[patch] Patch

bug-207860-20200217141911.patch (text/plain), 1.73 KB, created by Megan Gardner on 2020-02-17 14:19:13 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2020-02-17 14:19:13 PST

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 256766
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a9cd153e09215a81ee5d2ca9680a4b9db3ed7bd4..93ad4a302c77e72bd9630dc0589fdb560a52b052 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2020-02-17  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Send touches to data detectors gesture on macCataylst as the gesture currently runs on touch data.
>+        https://bugs.webkit.org/show_bug.cgi?id=207860
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The lookup gesture which run data detection needs touch information to function. Allow touches to be sent to the gesture. 
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
>+
> 2020-02-17  Youenn Fablet  <youenn@apple.com>
> 
>         Add WebInspector support to WebKit::WebSocketChannel
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index e1c2bb8725b61a04eee0baa700fd3b1e8fbb8e5f..0185951bdbd9cf6f3a3a328cd3a5f521186acd70 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1529,7 +1529,7 @@ - (void)_handleTouchActionsForTouchEvent:(const WebKit::NativeWebTouchEvent&)tou
> - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch
> {
> #if HAVE(HOVER_GESTURE_RECOGNIZER)
>-    if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch)
>+    if (gestureRecognizer != _lookupGestureRecognizer && (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch))
>         return NO;
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 207860: 390979 | 390983