Attachment 38882 Details for Bug 28887 – patch

[patch] patch

focusring.diff (text/plain), 2.61 KB, created by Evan Stade on 2009-09-01 13:15:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Evan Stade

Created: 2009-09-01 13:15:23 PDT

Size: 2.61 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 47946)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2009-09-01  Evan Stade  <estade@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Expose functions to change the focus ring color for Linux Chromium
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=28887
>+
>+        * rendering/RenderThemeChromiumLinux.cpp:
>+        (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
>+        (WebCore::RenderThemeChromiumLinux::setFocusRingColor):
>+        (WebCore::RenderThemeChromiumLinux::platformFocusRingColor):
>+        * rendering/RenderThemeChromiumLinux.h:
>+
> 2009-08-31  Jon Honeycutt  <jhoneycutt@apple.com>
> 
>         Remove the workaround added in r47316.
>Index: WebCore/rendering/RenderThemeChromiumLinux.cpp
>===================================================================
>--- WebCore/rendering/RenderThemeChromiumLinux.cpp	(revision 47946)
>+++ WebCore/rendering/RenderThemeChromiumLinux.cpp	(working copy)
>@@ -44,6 +44,7 @@ PassRefPtr<RenderTheme> RenderTheme::the
> }
> 
> RenderThemeChromiumLinux::RenderThemeChromiumLinux()
>+    : m_useDefaultFocusRingColor(true)
> {
> }
> 
>@@ -91,6 +92,19 @@ Color RenderThemeChromiumLinux::inactive
>     return Color(0x32, 0x32, 0x32);
> }
> 
>+void RenderThemeChromiumLinux::setFocusRingColor(const Color& color)
>+{
>+    m_focusRingColor = color;
>+    m_useDefaultFocusRingColor = false;
>+}
>+
>+Color RenderThemeChromiumLinux::platformFocusRingColor() const
>+{
>+    if (m_useDefaultFocusRingColor)
>+        return RenderThemeChromiumSkia::platformFocusRingColor();
>+    return m_focusRingColor;
>+}
>+
> bool RenderThemeChromiumLinux::supportsControlTints() const
> {
>     return true;
>Index: WebCore/rendering/RenderThemeChromiumLinux.h
>===================================================================
>--- WebCore/rendering/RenderThemeChromiumLinux.h	(revision 47946)
>+++ WebCore/rendering/RenderThemeChromiumLinux.h	(working copy)
>@@ -49,12 +49,18 @@ namespace WebCore {
>         virtual Color inactiveListBoxSelectionBackgroundColor() const;
>         virtual Color inactiveListBoxSelectionForegroundColor() const;
> 
>+        void setFocusRingColor(const Color& color);
>+        virtual Color platformFocusRingColor() const;
>+
>     private:
>         RenderThemeChromiumLinux();
>         virtual ~RenderThemeChromiumLinux();
> 
>         // A general method asking if any control tinting is supported at all.
>         virtual bool supportsControlTints() const;
>+
>+        Color m_focusRingColor;
>+        bool m_useDefaultFocusRingColor;
>     };
> 
> } // namespace WebCore

Flags:

levin: review+
levin: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 28887: 38882 | 38934