Attachment 388286 Details for Bug 205335 – Patch

[patch] Patch

wk2-webgl-setting.diff (text/plain), 2.33 KB, created by Carlos Garcia Campos on 2020-01-21 01:10:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2020-01-21 01:10:59 PST

Size: 2.33 KB

patch

obsolete

>diff --git a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>index b68c9131b30..e14fbc5726c 100644
>--- a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>+++ b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>@@ -1060,16 +1060,15 @@ static void webkit_settings_class_init(WebKitSettingsClass* klass)
>     /**
>     * WebKitSettings:enable-webgl:
>     *
>-    * Enable or disable support for WebGL on pages. WebGL is an experimental
>-    * proposal for allowing web pages to use OpenGL ES-like calls directly. The
>-    * standard is currently a work-in-progress by the Khronos Group.
>+    * Enable or disable support for WebGL on pages. WebGL enables web
>+    * content to use an API based on OpenGL ES 2.0.
>     */
>     g_object_class_install_property(gObjectClass,
>                                     PROP_ENABLE_WEBGL,
>                                     g_param_spec_boolean("enable-webgl",
>                                                          _("Enable WebGL"),
>                                                          _("Whether WebGL content should be rendered"),
>-                                                         FALSE,
>+                                                         TRUE,
>                                                          readWriteConstructParamFlags));
> 
>     /**
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp b/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
>index 4683fb8c98c..026a38872ba 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
>@@ -236,10 +236,10 @@ static void testWebKitSettings(Test*, gconstpointer)
>     webkit_settings_set_enable_webaudio(settings, FALSE);
>     g_assert_false(webkit_settings_get_enable_webaudio(settings));
> 
>-    // WebGL is disabled by default.
>-    g_assert_false(webkit_settings_get_enable_webgl(settings));
>-    webkit_settings_set_enable_webgl(settings, TRUE);
>+    // WebGL is enabled by default.
>     g_assert_true(webkit_settings_get_enable_webgl(settings));
>+    webkit_settings_set_enable_webgl(settings, FALSE);
>+    g_assert_false(webkit_settings_get_enable_webgl(settings));
> 
>     // Allow Modal Dialogs is disabled by default.
>     g_assert_false(webkit_settings_get_allow_modal_dialogs(settings));

Flags:

aperez: review+
aperez: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 205335: 388286