Attachment 376183 Details for Bug 200677 – Patch

[patch] Patch

200677.patch (text/plain), 1.62 KB, created by Michael Saboff on 2019-08-13 11:16:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2019-08-13 11:16:11 PDT

Size: 1.62 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 248600)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-08-13  Michael Saboff  <msaboff@apple.com>
>+
>+        REGRESSION (r248533): JSC Command - Need to initializeMainThread() before processing config file
>+        https://bugs.webkit.org/show_bug.cgi?id=200677
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We need to initialize the main thread before calling processConfigFile() since it uses RefCounted objects
>+        which have "is main thread" ASSERTS.
>+
>+        * jsc.cpp:
>+        (jscmain):
>+
> 2019-08-13  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         JSContext Inspector: Basic CommandLineAPI doesn't work
>Index: Source/JavaScriptCore/jsc.cpp
>===================================================================
>--- Source/JavaScriptCore/jsc.cpp	(revision 248595)
>+++ Source/JavaScriptCore/jsc.cpp	(working copy)
>@@ -3056,6 +3056,8 @@ int jscmain(int argc, char** argv)
>     // Need to override and enable restricted options before we start parsing options below.
>     Options::enableRestrictedOptions(true);
> 
>+    WTF::initializeMainThread();
>+
>     // Note that the options parsing can affect VM creation, and thus
>     // comes first.
>     CommandLine options(argc, argv);
>@@ -3063,7 +3065,6 @@ int jscmain(int argc, char** argv)
>     processConfigFile(Options::configFile(), "jsc");
> 
>     // Initialize JSC before getting VM.
>-    WTF::initializeMainThread();
>     JSC::initializeThreading();
>     startTimeoutThreadIfNeeded();
> #if ENABLE(WEBASSEMBLY)

Actions: View | Formatted Diff | Diff

Attachments on bug 200677: 376183