Attachment 308908 Details for Bug 171603 – Patch

[patch] Patch

bug-171603-20170503110741.patch (text/plain), 3.11 KB, created by Michael Catanzaro on 2017-05-03 09:07:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2017-05-03 09:07:42 PDT

Size: 3.11 KB

patch

obsolete

>Subversion Revision: 216117
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a27d05be69bd5ba25c525d26b546286a1ee0179e..8f11338f25275f06a9dbacc3a8d9aea9525174e6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        YouTube user agent quirk breaks new YouTube
>+        https://bugs.webkit.org/show_bug.cgi?id=171603
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
>+        attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
>+        have to remove this quirk.
>+
>+        Note this does not affect Safari as Apple ports don't use our user agent quirks.
>+
>+        * platform/UserAgentQuirks.cpp:
>+        (WebCore::urlRequiresChromeBrowser):
>+
> 2017-05-03  Antti Koivisto  <antti@apple.com>
> 
>         Rename StyleInvalidationAnalysis to Style::Invalidator
>diff --git a/Source/WebCore/platform/UserAgentQuirks.cpp b/Source/WebCore/platform/UserAgentQuirks.cpp
>index 4284a6878a5a6cd69d66d06df3785d32a79c543d..bdd82dab461449e2fe3da757e7813bbaf7cc8e35 100644
>--- a/Source/WebCore/platform/UserAgentQuirks.cpp
>+++ b/Source/WebCore/platform/UserAgentQuirks.cpp
>@@ -66,10 +66,6 @@ static bool urlRequiresChromeBrowser(const URL& url)
>     if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
>         return true;
> 
>-    // Needed for YouTube 360 with WebKitGTK+ and WPE (requires ENABLE_MEDIA_SOURCE).
>-    if (baseDomain == "youtube.com")
>-        return true;
>-
>     // Slack completely blocks users with WebKitGTK+'s standard user agent.
>     if (baseDomain == "slack.com")
>         return true;
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 4b1841eb82f8c2427f9df28a5cd0f1459c1397d4..732c23816cae51144839eb8361008c4f5107d6ae 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        YouTube user agent quirk breaks new YouTube
>+        https://bugs.webkit.org/show_bug.cgi?id=171603
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove the YouTube quirk test.
>+
>+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2017-05-02  David Kilzer  <ddkilzer@apple.com>
> 
>         check-webkit-style should also keep js-test-post[-async].js in sync
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>index 9c275ec168535edd0dd627ea3a7c9b556595dc91..2cb6664df3f7b59a0d38d6e446f21ebc312c7bc3 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>@@ -89,7 +89,6 @@ TEST(UserAgentTest, Quirks)
> 
>     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
>     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
>-    assertUserAgentForURLHasChromeBrowserQuirk("http://www.youtube.com/");
>     assertUserAgentForURLHasChromeBrowserQuirk("http://www.slack.com/");
> 
>     assertUserAgentForURLHasFirefoxBrowserQuirk("http://www.google.com/");

Actions: View | Formatted Diff | Diff

Attachments on bug 171603: 308908