Attachment 302575 Details for Bug 168778 – Patch for landing

[patch] Patch for landing

bug-168778-20170223141852.patch (text/plain), 1.89 KB, created by youenn fablet on 2017-02-23 14:21:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2017-02-23 14:21:40 PST

Size: 1.89 KB

patch

obsolete

>Subversion Revision: 212924
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 579f1cfd4667f28923335b8e9b4641b942dbb743..de3cb5883d32e2bd84faaf33a04e91ea56d8a4fb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2017-02-23  Youenn Fablet  <youenn@apple.com>
>+
>+        [WebRTC] Outgoing video quality is poor
>+        https://bugs.webkit.org/show_bug.cgi?id=168778
>+        <rdar://problem/30674673>
>+
>+        Reviewed by Eric Carlson.
>+
>+        Covered by manually ensuring the voice process thread is not spinning.
>+
>+        * platform/mediastream/libwebrtc/LibWebRTCAudioModule.h: Setting the next call to max was not a good idea since the thread process is adding some value to it, making it a negative value.
>+
> 2017-02-23  Chris Dumez  <cdumez@apple.com>
> 
>         Report domains using abnormally high CPU usage via enhanced privacy logging
>diff --git a/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h b/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
>index 95988609d178e56369159b352632eec1ebb979fc..33242fec19d53f40c0e91568672f1fa745c0850a 100644
>--- a/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
>+++ b/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
>@@ -56,7 +56,8 @@ private:
>     int32_t RegisterAudioCallback(webrtc::AudioTransport*) final;
>     bool Playing() const final { return m_isPlaying; }
> 
>-    int64_t TimeUntilNextProcess() final { return std::numeric_limits<int64_t>::max(); }
>+    // Set it to a big value so that we are not called often but not close to int64_t max so that it does not create integer overflows.
>+    int64_t TimeUntilNextProcess() final { return 100000000; }
>     void Process() final { }
>     int32_t ActiveAudioLayer(AudioLayer*) const final { return shouldNotBeCalled(-1); }
>     ErrorCode LastError() const final { return kAdmErrNone; }

Actions: View | Formatted Diff | Diff

Attachments on bug 168778: 302562 | 302575