Attachment 264966 Details for Bug 148853 – WIP Patch

[patch] WIP Patch

148853_embed_noRenderer.patch (text/plain), 9.51 KB, created by Chris Dumez on 2015-11-06 15:39:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2015-11-06 15:39:37 PST

Size: 9.51 KB

patch

obsolete

>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 55a2490..dedc03d 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -294,8 +294,6 @@ imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-twi
> 
> # New W3C ref tests that are failing.
> webkit.org/b/148847 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html [ ImageOnlyFailure ]
>-webkit.org/b/148853 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-01.html [ ImageOnlyFailure ]
>-webkit.org/b/148853 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-02.html [ ImageOnlyFailure ]
> webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ]
> 
> # @supports W3C Failures
>diff --git a/LayoutTests/accessibility/inline-block-assertion-expected.txt b/LayoutTests/accessibility/inline-block-assertion-expected.txt
>index 698003a..45b4aab 100644
>--- a/LayoutTests/accessibility/inline-block-assertion-expected.txt
>+++ b/LayoutTests/accessibility/inline-block-assertion-expected.txt
>@@ -1,4 +1,4 @@
>- 
>+
> Make sure that an inline block element is not cast incorrectly causing an assertion.
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>diff --git a/LayoutTests/editing/execCommand/crash-140261-expected.txt b/LayoutTests/editing/execCommand/crash-140261-expected.txt
>index b0d47ca..e1fbd8d 100644
>--- a/LayoutTests/editing/execCommand/crash-140261-expected.txt
>+++ b/LayoutTests/editing/execCommand/crash-140261-expected.txt
>@@ -1,4 +1,4 @@
>-  
>+
> Test for crash in WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock()
> 
> This test passes if it doesn't crash.
>diff --git a/LayoutTests/fast/block/float/4145535Crash-expected.txt b/LayoutTests/fast/block/float/4145535Crash-expected.txt
>index 93ae260..08804f2 100644
>--- a/LayoutTests/fast/block/float/4145535Crash-expected.txt
>+++ b/LayoutTests/fast/block/float/4145535Crash-expected.txt
>@@ -3,6 +3,4 @@ layer at (0,0) size 800x600
> layer at (0,0) size 800x600
>   RenderBlock {HTML} at (0,0) size 800x600
>     RenderBody {BODY} at (8,8) size 784x584
>-      RenderBlock (anonymous) at (0,0) size 784x150
>-        RenderEmbeddedObject {EMBED} at (0,0) size 300x150
>-      RenderTable {TABLE} at (0,150) size 0x0
>+      RenderTable {TABLE} at (0,0) size 0x0
>diff --git a/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt b/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt
>index 102825f..cb2dcbc 100644
>--- a/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt
>+++ b/LayoutTests/fast/dom/HTMLDocument/document-plugins-expected.txt
>@@ -3,5 +3,3 @@ This test checks for whether document.plugins matches document.embeds.
> If the test passes, you will see a pass message below.
> 
> PASS
>-
>- 
>diff --git a/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt b/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt
>index af65951..69cfc5a 100644
>--- a/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt
>+++ b/LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt
>@@ -1,2 +1,2 @@
>-PASS 
>+PASS
> 
>diff --git a/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt b/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt
>index ac8167d..7ef22e9 100644
>--- a/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt
>+++ b/LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt
>@@ -1 +1 @@
>-PASS  
>+PASS
>diff --git a/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt b/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt
>index 6a6ade9..5a7beb1 100644
>--- a/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt
>+++ b/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt
>@@ -35,4 +35,4 @@ codeBase
> hspace
> object
> vspace
>- 
>+
>diff --git a/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html b/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html
>index 3510e56..922c98e 100644
>--- a/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html
>+++ b/LayoutTests/fast/replaced/percent-height-in-anonymous-block-widget.html
>@@ -5,7 +5,7 @@
>     </p>
>     <div style="height: 50px; background: blue; width: 100px;" id="target">
>         <div></div>
>-        <embed id="object" style="height: 100%;">
>+        <embed id="object" type="video/quicktime" style="height: 100%;">
>     </div>
> </body>
> <script>
>diff --git a/LayoutTests/fast/replaced/replaced-breaking.html b/LayoutTests/fast/replaced/replaced-breaking.html
>index bc53eb7..6b190af 100644
>--- a/LayoutTests/fast/replaced/replaced-breaking.html
>+++ b/LayoutTests/fast/replaced/replaced-breaking.html
>@@ -15,7 +15,7 @@
>         <input type="checkbox"><input type="checkbox">
>         <input type="radio"><input type="radio">
>         <iframe></iframe><iframe></iframe>
>-        <embed></embed><embed></embed>
>+        <embed type="video/quicktime"></embed><embed type="video/quicktime"></embed>
>     </div>
> </body>
> </html>
>diff --git a/LayoutTests/fast/replaced/table-percent-height.html b/LayoutTests/fast/replaced/table-percent-height.html
>index ec52089..44eb8a9 100644
>--- a/LayoutTests/fast/replaced/table-percent-height.html
>+++ b/LayoutTests/fast/replaced/table-percent-height.html
>@@ -143,8 +143,8 @@ function test()
> <table><tr><td><canvas id="canvas-75" style="background-color: #00ff00; height: 75%;"></canvas></td></tr></table>
> <table><tr><td><canvas id="canvas-100" style="background-color: #00ff00; height: 100%;"></canvas></td></tr></table>
> 
>-<table><tr><td><embed id="embed-75" style="background-color: #00ff00; height: 75%;"></embed></td></tr></table>
>-<table><tr><td><embed id="embed-100" style="background-color: #00ff00; height: 100%;"></embed></td></tr></table>
>+<table><tr><td><embed id="embed-75" type="video/quicktime" style="background-color: #00ff00; height: 75%;"></embed></td></tr></table>
>+<table><tr><td><embed id="embed-100" type="video/quicktime" style="background-color: #00ff00; height: 100%;"></embed></td></tr></table>
> 
> <table><tr><td><img id="img-75" src="resources/square-blue-100x100.png" style="height: 75%;"></td></tr></table>
> <table><tr><td><img id="img-100" src="resources/square-blue-100x100.png" style="height: 100%;"></td></tr></table>
>diff --git a/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt b/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt
>index 8474137..ace3cba 100644
>--- a/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt
>+++ b/LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt
>@@ -1 +1 @@
>-PASS, if no exception or crash in debug  
>+PASS, if no exception or crash in debug
>diff --git a/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt b/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt
>index 9545c98..199191d 100644
>--- a/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt
>+++ b/LayoutTests/imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt
>@@ -1,3 +1,3 @@
> This test checks that adding a positioned block grid item after an inline grid item (which inserts it inside the existing anonymous block wrapping the inline item) does not crash on debug.
> 
>-test 
>+test
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt
>index 8658d8a..bbd0028 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt
>@@ -1,4 +1,4 @@
>-      
>+    
>   
> 
> PASS getElementsByName and newly introduced HTML elements 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt
>index 44a5d1e..3aeca00 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt
>@@ -1,4 +1,3 @@
>-              
> 
> PASS If there is one embed, it should be returned (name) 
> PASS If there are two embeds, a collection should be returned. (name) 
>diff --git a/Source/WebCore/html/HTMLEmbedElement.cpp b/Source/WebCore/html/HTMLEmbedElement.cpp
>index c69d7f1..b85adfa 100644
>--- a/Source/WebCore/html/HTMLEmbedElement.cpp
>+++ b/Source/WebCore/html/HTMLEmbedElement.cpp
>@@ -183,6 +183,9 @@ void HTMLEmbedElement::updateWidget(PluginCreationOption pluginCreationOption)
> 
> bool HTMLEmbedElement::rendererIsNeeded(const RenderStyle& style)
> {
>+    if (!fastHasAttribute(typeAttr) && !fastHasAttribute(srcAttr))
>+        return false;
>+
>     if (isImageType())
>         return HTMLPlugInImageElement::rendererIsNeeded(style);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 148853: 264966 | 264974