Attachment 237187 Details for Bug 136160 – patch

[patch] patch

patch.diff (text/plain), 1.46 KB, created by Saam Barati on 2014-08-26 17:15:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2014-08-26 17:15:37 PDT

Size: 1.46 KB

patch

obsolete

>Index: Source/WebInspectorUI/ChangeLog
>===================================================================
>--- Source/WebInspectorUI/ChangeLog	(revision 172987)
>+++ Source/WebInspectorUI/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2014-08-26  Saam Barati  <sbarati@apple.com>
>+
>+        Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
>+        https://bugs.webkit.org/show_bug.cgi?id=136160
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Check if '_tracking' is already true before calling '_startTracking'
>+        to prevent the assertion from always firing.
>+
>+
>+        * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
>+        (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
>+
> 2014-08-25  Brent Fulgham  <bfulgham@apple.com>
> 
>         [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
>Index: Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js	(revision 172969)
>+++ Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js	(working copy)
>@@ -261,7 +261,8 @@ WebInspector.CodeMirrorTokenTrackingCont
> 
>     _mouseEntered: function(event)
>     {
>-        this._startTracking();
>+        if (!this._tracking)
>+            this._startTracking();
>     },
> 
>     _mouseLeft: function(event)

Actions: View | Formatted Diff | Diff

Attachments on bug 136160: 236990 | 236991 | 237187 | 237188