RESOLVED FIXED 136160
Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion 
https://bugs.webkit.org/show_bug.cgi?id=136160
Summary Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
Saam Barati
Reported 2014-08-22 10:39:00 PDT
This assertion fires often, but it doesn't indicate any kind of noteworthy error. _startTracking should either remove its assert if it wants to allow those that call it to call it regardless of if it's already tracking, or those that call _startTracking should only call it if _tracking is false.
Attachments
patch (618 bytes, patch)
2014-08-22 10:40 PDT, Saam Barati 		timothy: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
patch (567 bytes, patch)
2014-08-22 10:42 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (1.46 KB, patch)
2014-08-26 17:15 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (1.46 KB, patch)
2014-08-26 17:16 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-22 10:39:24 PDT
<rdar://problem/18103437>
Saam Barati
Comment 2 2014-08-22 10:40:54 PDT
Created attachment 236990 [details] patch I think this is the cause of the assertion constantly firing.
Saam Barati
Comment 3 2014-08-22 10:42:13 PDT
Created attachment 236991 [details] patch And this is another solution.
Timothy Hatcher
Comment 4 2014-08-23 09:00:34 PDT
That assert is pretty annoying. I think _mouseEntered should check.
Saam Barati
Comment 5 2014-08-23 19:17:13 PDT
(In reply to comment #4) > That assert is pretty annoying. I think _mouseEntered should check. I agree. I'll submit a patch to do this.
Saam Barati
Comment 6 2014-08-26 17:15:37 PDT
Created attachment 237187 [details] patch
Saam Barati
Comment 7 2014-08-26 17:16:16 PDT
Created attachment 237188 [details] patch
WebKit Commit Bot
Comment 8 2014-08-26 17:53:04 PDT
Comment on attachment 237188 [details] patch Clearing flags on attachment: 237188 Committed r172991: <http://trac.webkit.org/changeset/172991>
WebKit Commit Bot
Comment 9 2014-08-26 17:53:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.