Attachment 225677 Details for Bug 129614 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

ooooo.patch (text/plain), 1.66 KB, created by Joseph Pecoraro on 2014-03-03 11:53:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2014-03-03 11:53:45 PST

Size: 1.66 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 726a122..8a31093 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2014-03-03  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        filter-build-webkit should not strip .o
>+        https://bugs.webkit.org/show_bug.cgi?id=129614
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This makes it much easier to jump from the failing output at
>+        the end back up to the compile errors earlier in the output.
>+
>+        * Scripts/filter-build-webkit:
>+
> 2014-02-28  Zalan Bujtas  <zalan@apple.com>
> 
>         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
>diff --git a/Tools/Scripts/filter-build-webkit b/Tools/Scripts/filter-build-webkit
>index 57c3303..6a494e4 100755
>--- a/Tools/Scripts/filter-build-webkit
>+++ b/Tools/Scripts/filter-build-webkit
>@@ -144,7 +144,7 @@ for (my $previousLine = "", my $line = <>; $line; $previousLine = $line, $line =
>         printLine("Build Succeeded", STYLE_SUCCESS);
>     } elsif ($line =~ /^(\e\[1m)?(PhaseScriptExecution|ClCompile|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|ProcessProductPackaging|CodeSign|SymLink|Updating|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile)(\e\[0m)? ("[^"]+"|(\\|(?<=\\)\s|\S)+)?/) {
>         my ($command, $path) = ($2, basename($4));
>-        $path =~ s/("|\\|\.[oah]$)//g;
>+        $path =~ s/("|\\|\.[ah]$)//g;
>         printLine("$command $path", STYLE_PLAIN);
>     } elsif ($line =~ /^\S+mkdir .*?(\S+)$/) {
>         my $path = basename($1);

Actions: View | Formatted Diff | Diff

Attachments on bug 129614: 225677