Attachment 15639 Details for Bug 14717 – the fix - inline some new methods

[patch] the fix - inline some new methods

window-js-regression.patch.txt (text/plain), 2.34 KB, created by Maciej Stachowiak on 2007-07-22 19:40:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Maciej Stachowiak

Created: 2007-07-22 19:40:57 PDT

Size: 2.34 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 24524)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2007-07-22  Maciej Stachowiak  <mjs@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        <rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
>+        http://bugs.webkit.org/show_bug.cgi?id=14717
>+        
>+        * bindings/js/kjs_window.cpp:
>+        * bindings/js/kjs_window.h:
>+        (KJS::Window::impl): inlined
>+        * page/DOMWindow.cpp:
>+        * page/DOMWindow.h:
>+        (WebCore::DOMWindow::frame): inlined
>+
> 2007-07-22  Darin Adler  <darin@apple.com>
> 
>         Reviewed by Kevin Decker.
>Index: bindings/js/kjs_window.cpp
>===================================================================
>--- bindings/js/kjs_window.cpp	(revision 24489)
>+++ bindings/js/kjs_window.cpp	(working copy)
>@@ -239,11 +239,6 @@ Window::~Window()
>         i1->second->clearWindowObj();
> }
> 
>-DOMWindow* Window::impl() const
>-{
>-     return m_impl.get();
>-}
>-
> ScriptInterpreter* Window::interpreter() const
> {
>     Frame* frame = impl()->frame();
>Index: bindings/js/kjs_window.h
>===================================================================
>--- bindings/js/kjs_window.h	(revision 24489)
>+++ bindings/js/kjs_window.h	(working copy)
>@@ -73,7 +73,7 @@ namespace KJS {
>     Window(WebCore::DOMWindow*);
>   public:
>     ~Window();
>-    WebCore::DOMWindow* impl() const;
>+    WebCore::DOMWindow* impl() const { return m_impl.get(); }
>     void disconnectFrame();
>     /**
>      * Returns and registers a window object. In case there's already a Window
>Index: page/DOMWindow.cpp
>===================================================================
>--- page/DOMWindow.cpp	(revision 24489)
>+++ page/DOMWindow.cpp	(working copy)
>@@ -55,11 +55,6 @@ DOMWindow::~DOMWindow()
> {
> }
> 
>-Frame* DOMWindow::frame()
>-{
>-    return m_frame;
>-}
>-
> void DOMWindow::disconnectFrame()
> {
>     m_frame = 0;
>Index: page/DOMWindow.h
>===================================================================
>--- page/DOMWindow.h	(revision 24489)
>+++ page/DOMWindow.h	(working copy)
>@@ -48,7 +48,7 @@ namespace WebCore {
>         DOMWindow(Frame*);
>         virtual ~DOMWindow();
> 
>-        Frame* frame();
>+        Frame* frame() { return m_frame; }
>         void disconnectFrame();
> 
>         void clear();

Flags:

aroben: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 14717: 15639