Attachment 152624 Details for Bug 91428 – Patch

[patch] Patch

bug-91428-20120716152423.patch (text/plain), 1.91 KB, created by Alexandre Elias on 2012-07-16 15:24:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexandre Elias

Created: 2012-07-16 15:24:24 PDT

Size: 1.91 KB

patch

obsolete

>Subversion Revision: 122374
>diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
>index d4772eddbd23da5df407e0ca88affa05673d659d..e673e5b4bca7b7350b4a9f8e31f05f2d71c1fd4f 100644
>--- a/Source/WebKit/chromium/ChangeLog
>+++ b/Source/WebKit/chromium/ChangeLog
>@@ -1,3 +1,22 @@
>+2012-07-16  Alexandre Elias  <aelias@google.com>
>+
>+        [chromium] Fix WebFrameTest flakiness due to synthetic mouse events
>+        https://bugs.webkit.org/show_bug.cgi?id=91428
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Synthetic mouse move events on scrolling can cause segfaults in
>+        WebFrameTest due to delayed callbacks on the message loop after
>+        state destruction. This is currently only affecting
>+        the Android port, but has the potential to affect other platforms in the
>+        future.
>+
>+        We can avoid the issue by disabling the deviceSupportsMouse
>+        setting, which shouldn't be needed by any WebFrameTest.
>+
>+        * tests/FrameTestHelpers.cpp:
>+        (WebKit::FrameTestHelpers::createWebViewAndLoad):
>+
> 2012-07-11  Dana Jansens  <danakj@chromium.org>
> 
>         [chromium] Rename layerRect to contentRect for rects that live in content space
>diff --git a/Source/WebKit/chromium/tests/FrameTestHelpers.cpp b/Source/WebKit/chromium/tests/FrameTestHelpers.cpp
>index a2b1675c09beeb4646fdd3033ad3bc874d25ad98..c3e8bf08ddbf6d9c83397bfb9c08a8f365957627 100644
>--- a/Source/WebKit/chromium/tests/FrameTestHelpers.cpp
>+++ b/Source/WebKit/chromium/tests/FrameTestHelpers.cpp
>@@ -80,6 +80,7 @@ WebView* createWebViewAndLoad(const std::string& url, bool enableJavascript, Web
>         webViewClient = defaultWebViewClient();
>     WebView* webView = WebView::create(webViewClient);
>     webView->settings()->setJavaScriptEnabled(enableJavascript);
>+    webView->settings()->setDeviceSupportsMouse(false);
>     webView->initializeMainFrame(webFrameClient);
> 
>     loadFrame(webView->mainFrame(), url);

Actions: View | Formatted Diff | Diff

Attachments on bug 91428: 152624