Attachment 139866 Details for Bug 19702 – Right patch

[patch] Right patch

fix19702b (text/plain), 2.67 KB, created by Ryosuke Niwa on 2012-05-02 13:12:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2012-05-02 13:12:07 PDT

Size: 2.67 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 115796)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2012-05-01  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        blockquote gets clobbered on delete, but the font-tag inside it doesn't
>+        https://bugs.webkit.org/show_bug.cgi?id=19702
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a regression test initially authored by Ojan Vafai since this bug appears to have been fixed already.
>+
>+        * editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt: Added.
>+        * editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html: Added.
>+
> 2012-05-01  Eric Seidel  <eric@webkit.org>
> 
>         Add <iframe seamless> navigation code (and pass all the navigation tests)
>Index: LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html
>===================================================================
>--- LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html	(revision 0)
>+++ LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html	(revision 0)
>@@ -0,0 +1,23 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<div id="container" contenteditable>
>+<blockquote style="background-color:yellow"><br><font style="color:blue"><br>&nbsp;world
>+</font></blockquote>
>+</div>
>+<script src="../../resources/dump-as-markup.js"></script>
>+<script>
>+
>+Markup.description('This tests deleting a line inside a font element inside a blockquote.')
>+
>+var font = document.querySelector('font');
>+getSelection().collapse(font, 0);
>+getSelection().modify('Extend', 'Forward', 'Line');
>+document.execCommand('Delete', false, null);
>+document.execCommand('InsertText', false, 'hello');
>+
>+Markup.dump('container', 'There should be exactly one blockquote and you should see "hello world" below')
>+
>+</script>
>+</body>
>+</html>
>Index: LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt
>===================================================================
>--- LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt	(revision 0)
>+++ LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt	(revision 0)
>@@ -0,0 +1,14 @@
>+This tests deleting a line inside a font element inside a blockquote.
>+
>+There should be exactly one blockquote and you should see "hello world" below:
>+| "
>+"
>+| <blockquote>
>+|   style="background-color:yellow"
>+|   <br>
>+|   <font>
>+|     style="color:blue"
>+|     "hello<#selection-caret> world
>+"
>+| "
>+"

Actions: View | Formatted Diff | Diff

Attachments on bug 19702: 21866 | 139753 | 139754 | 139866